Repository navigation
Pre-launch member removal + address-bound invites (spec) - #186
Closed
franrolotti wants to merge 1 commit into
Closed
franrolotti wants to merge 1 commit into
franrolotti wants to merge 1 commit into
Conversation
Contract-side spec for app-stacks#99 (general invite link with creator approval): adds removeMember (callable strictly before start) and binds invite signatures to the approved wallet, explains why an upgrade is required, why it is storage-safe, and how the contract, app, and Supabase changes together close the issue.
Contributor
Author
|
Repeated. Closing in favour of #185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract-side spec for the general invite link / creator-approval flow (app-stacks#99). Implementation will land on this branch.
The spec (docs/specs/approval-flow-upgrade.md) covers:
removeMember(id, member)— owner-only, callable strictly beforestart()(isActiveguard closes the window atomically at launch). No refund logic needed: deposits areonlyActive, so pre-start circles hold no member funds.Invite(uint256 id,uint256 nonce,address member)and_hashInvitesignsmsg.sender, so an approved invite is only redeemable by the vetted wallet (closes the bearer-token hole in the approval flow).constantin bytecode, EIP-712 domain state untouched, no reinitializer. Hard gate: identicalforge inspect SavingCircles storage-layoutbetweendevand this branch.104-deploy-guardrails(commit 9f3de5f, not yet ondev) to executeProxyAdmin.upgradeAndCall.Implementation checklist
removeMember+MemberRemovedevent inSavingCirclesandISavingCircles_INVITE_TYPEHASH/_hashInviteapp/invites.tsx+app/invites.test.tsto the new typed dataremoveMemberforge inspectstorage-layout diff empty vsdev104-deploy-guardrailsCoordinated release note: unredeemed old-format invite links stop validating at the upgrade (
InvalidSigner), so the app-stacks change that signs member-bound invites ships in the same window.