feat: pluggable signature schemes — generic chassis, ECDSA scheme, certificate taps - #185
Merged
bagelface merged 4 commits intoJul 13, 2026
Conversation
bagelface
changed the base branch from
bagelface/integrate-aggregation-engine
to
main
July 10, 2026 16:43
bagelface
changed the base branch from
main
to
bagelface/integrate-aggregation-engine
July 10, 2026 16:43
bagelface
changed the base branch from
bagelface/integrate-aggregation-engine
to
main
July 10, 2026 16:44
bagelface
force-pushed
the
bagelface/genericize-scheme-chassis
branch
from
July 12, 2026 23:03
30d0fdb to
ee5a089
Compare
bagelface
changed the base branch from
main
to
bagelface/integrate-aggregation-engine
July 13, 2026 12:03
bagelface
merged commit Jul 13, 2026
a3d0c59
into
bagelface/integrate-aggregation-engine
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #184. Makes the aggregation actor chassis generic over the certificate scheme and p2p identity, adds an ECDSA (secp256k1) scheme alongside BN254, and exposes the seams an application-side scheme needs to plug in — deliberately without shipping scheme-specific operational machinery in the library.
Informed by gas-killer/service#312 and gas-killer/service#314 (aggregate Schnorr): the library's job is to allow a variety of schemes, not to guarantee every scheme's tooling. Schemes that are pure single-shot
certificate::Schemeimplementations ship incoreas batteries; anything needing infrastructure beside the engine (nonce registries, spend journals, completion rounds) stays in the application, consuming the generic hooks added here.Changes
CertReporter<E, S>/CertifiedHeight<S>/NodeReporter<T, S>overS: certificate::Scheme; newCertIndextrait (get_tip/get) decoupling the sequencer from the concrete reporter —Sequencer<T, P, S, R: CertIndex, TS>; identity-genericingest/TipReports<P>/recipients. Matches the trait shapes the service converged on, so its migration to the library stays mechanical.core::ecdsa): operator's Ethereum key = p2p identity (20-byte address) = signing key; canonical low-s 65-byte signatures enforced at decode;EcdsaCertificate= signer bitmap + per-signer signatures in participant order.EcdsaSubmitter+EcdsaVerificationHandlerseam hand(operators[], signatures[])to the application (e.g. ERC-1271 stake-registry verification). No new bindings needed.CertificateObservation<S>opt-in channel (NodeReporter::with_certificate_tap), replay-deduplicated, carrying the opaqueS::Certificate— the hook an application-side actor (e.g. a Schnorr completion round) consumes; router-side observation was already generic viaCertifiedHeight<S>.BN254 remains fully supported and is the counter example's scheme — the example needed only type-annotation changes, demonstrating the genericization is behavior-preserving.
Validation
cargo check --workspace --all-targets, 83 tests (workspace, all passing),clippy --workspace --all-targets --all-features -- -D warnings,cargo fmt --check— all clean. New test coverage: full EcdsaScheme suite (quorum boundaries, tampered certificates, codec, ordering), tap delivery/replay-dedupe/dropped-receiver tests on the deterministic runtime.