fix: claim EVM swap without connected wallet - #1595
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe no-hop claim flow now uses a gas-abstraction-aware signer. Tests cover walletless pasted-destination claims, gas top-up support, persisted amounts, rescue-signer usage, and an Arbitrum L-BTC-to-TBTC end-to-end claim. ChangesWalletless claim signer
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12b4867 to
b6cc808
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/arbitrum/lbtcUsdt0.spec.ts`:
- Around line 114-116: Update the assertion around getStoredSwap so it first
requires a non-null stored swap, then checks that the persisted swap’s dex is
undefined. Do not use optional chaining for this validation, ensuring the test
fails when the swap is missing or unreadable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bf054011-7f6e-453d-a93f-b5128780b7eb
📒 Files selected for processing (3)
e2e/arbitrum/lbtcUsdt0.spec.tssrc/status/TransactionConfirmed.tsxtests/status/AutoClaimHops.spec.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- src/status/TransactionConfirmed.tsx
- tests/status/AutoClaimHops.spec.tsx
b6cc808 to
fab76ad
Compare
Summary by CodeRabbit
New Features
Bug Fixes