Skip to content

fix: claim EVM swap without connected wallet - #1595

Open
kiocos wants to merge 1 commit into
mainfrom
claim-evm-without-wallet
Open

fix: claim EVM swap without connected wallet#1595
kiocos wants to merge 1 commit into
mainfrom
claim-evm-without-wallet

Conversation

@kiocos

@kiocos kiocos commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Enabled ERC20 chain-swap claims without a connected wallet when gas abstraction is supported.
    • Added no-hop claims using a pasted destination address.
    • Added support for supported cross-chain swaps to pasted destinations.
  • Bug Fixes

    • Improved signer handling for gas-sponsored claims.
    • Preserved claim amounts and destinations during rescue claims.
    • Prevented incorrect missing-signer messages when a valid rescue signer is available.

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webapp-mainnet Ready Ready Preview Aug 1, 2026 7:16am
webapp-pro Ready Ready Preview Aug 1, 2026 7:16am

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 486abf67-1052-4d8e-a9aa-3d226a432f0d

📥 Commits

Reviewing files that changed from the base of the PR and between b6cc808 and fab76ad.

📒 Files selected for processing (3)
  • e2e/arbitrum/lbtcUsdt0.spec.ts
  • src/status/TransactionConfirmed.tsx
  • tests/status/AutoClaimHops.spec.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
  • e2e/arbitrum/lbtcUsdt0.spec.ts
  • src/status/TransactionConfirmed.tsx
  • tests/status/AutoClaimHops.spec.tsx

📝 Walkthrough

Walkthrough

The no-hop claim flow now uses a gas-abstraction-aware signer. Tests cover walletless pasted-destination claims, gas top-up support, persisted amounts, rescue-signer usage, and an Arbitrum L-BTC-to-TBTC end-to-end claim.

Changes

Walletless claim signer

Layer / File(s) Summary
Resolve the claim signer
src/status/TransactionConfirmed.tsx
The no-hop claim path resolves a gas-abstraction-aware signer, rejects when unavailable, and passes it to the claim callback.
Validate walletless claim behavior
tests/status/AutoClaimHops.spec.tsx, e2e/arbitrum/lbtcUsdt0.spec.ts
Tests configure gas top-up support and verify rescue-signer usage, pasted destination handling, persisted amount submission, missing-signer behavior, and completion of an L-BTC-to-TBTC claim.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kilrau, michael1011

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: enabling EVM swap claims without a connected wallet.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claim-evm-without-wallet

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@e2e/arbitrum/lbtcUsdt0.spec.ts`:
- Around line 114-116: Update the assertion around getStoredSwap so it first
requires a non-null stored swap, then checks that the persisted swap’s dex is
undefined. Do not use optional chaining for this validation, ensuring the test
fails when the swap is missing or unreadable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bf054011-7f6e-453d-a93f-b5128780b7eb

📥 Commits

Reviewing files that changed from the base of the PR and between 12b4867 and b6cc808.

📒 Files selected for processing (3)
  • e2e/arbitrum/lbtcUsdt0.spec.ts
  • src/status/TransactionConfirmed.tsx
  • tests/status/AutoClaimHops.spec.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/status/TransactionConfirmed.tsx
  • tests/status/AutoClaimHops.spec.tsx

Comment thread e2e/arbitrum/lbtcUsdt0.spec.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant