Skip to content

ci: harden UltraModern GitHub Actions workflows #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BleedingDev merged 1 commit into from
Jun 26, 2026
Merged

ci: harden UltraModern GitHub Actions workflows #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/check-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 1
persist-credentials: false

- name: Setup Node.js 22
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest

permissions:
contents: write
contents: read
issues: write
pull-requests: write
steps:
Expand All @@ -26,6 +26,7 @@ jobs:
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}
persist-credentials: false

- name: Setup mise
uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/docs-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ on:

permissions:
contents: read
pages: write
id-token: write

concurrency:
group: docs-pages
Expand All @@ -18,9 +16,13 @@ concurrency:
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
Comment on lines +19 to +20

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Grant Pages read permission to the build job

When this workflow is used from a private repository or fork, actions/configure-pages@v6 calls the GitHub Pages getPages API, which requires Pages read permission. This job-level permissions block grants only contents: read (unspecified scopes become none), so the Configure Pages step fails with Resource not accessible by integration before any artifact is uploaded; add pages: read to the build job while keeping write/OIDC limited to deploy.

Useful? React with 👍 / 👎.

steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Configure Pages
uses: actions/configure-pages@45bfe0192ca1faeb007ade9deae92b16b8254a0d # v6.0.0
Expand Down Expand Up @@ -57,6 +59,9 @@ jobs:
deploy:
needs: build
runs-on: ubuntu-latest
permissions:
pages: write
id-token: write
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/integration-test-Linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
persist-credentials: false

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve credentials before running skipCI

When this workflow runs in a private/internal repository, the immediately following Check skip CI step invokes scripts/skipCI.js, which starts with git fetch origin main. actions/checkout documents that persisted credentials are what let later scripts run authenticated git commands, and setting persist-credentials: false opts out, so that fetch will fail before the tests can run or be skipped. This same pattern is repeated in the other skip-CI workflows changed here; either keep credentials for these jobs or authenticate the fetch explicitly.

Useful? React with 👍 / 👎.


- name: Check skip CI
run: echo "RESULT=$(node ./scripts/skipCI.js)" >> "$GITHUB_OUTPUT"
id: skip-ci

- name: Log skip CI result
run: echo "${{steps.skip-ci.outputs.RESULT}}"
env:
SKIP_CI_RESULT: ${{ steps.skip-ci.outputs.RESULT }}
run: echo "$SKIP_CI_RESULT"

- name: Setup Node.js 26.x
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/integration-test-Windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
persist-credentials: false

- name: Setup mise
uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
Expand All @@ -46,7 +47,9 @@ jobs:
id: skip-ci

- name: Log skip CI result
run: echo "${{steps.skip-ci.outputs.RESULT}}"
env:
SKIP_CI_RESULT: ${{ steps.skip-ci.outputs.RESULT }}
run: echo "$env:SKIP_CI_RESULT"

- name: Setup Node.js 26.x
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/lint-Linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
# This makes Actions fetch only one branch to release
fetch-depth: 1
fetch-depth: 1
persist-credentials: false

- name: Setup mise
uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-builder-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 1
persist-credentials: false

- name: Nx Cache
id: nx-cache
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/type-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 1
persist-credentials: false

- name: Setup Node.js 22
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand All @@ -41,7 +42,9 @@ jobs:
id: skip-ci

- name: Log skip CI result
run: echo "${{steps.skip-ci.outputs.RESULT}}"
env:
SKIP_CI_RESULT: ${{ steps.skip-ci.outputs.RESULT }}
run: echo "$SKIP_CI_RESULT"

- name: Nx Cache
id: nx-cache
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/ut-Windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 1
persist-credentials: false

- name: Setup mise
uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
Expand All @@ -42,7 +43,9 @@ jobs:
id: skip-ci

- name: Log skip CI result
run: echo "${{steps.skip-ci.outputs.RESULT}}"
env:
SKIP_CI_RESULT: ${{ steps.skip-ci.outputs.RESULT }}
run: echo "$env:SKIP_CI_RESULT"

- name: Setup Node.js 26.x
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/ut-macOS.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 1
persist-credentials: false

- name: Setup mise
uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
Expand All @@ -41,7 +42,9 @@ jobs:
id: skip-ci

- name: Log skip CI result
run: echo "${{steps.skip-ci.outputs.RESULT}}"
env:
SKIP_CI_RESULT: ${{ steps.skip-ci.outputs.RESULT }}
run: echo "$SKIP_CI_RESULT"

- name: Setup Node.js 26.x
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand Down
Loading