Skip to content

Add fatal for faulty XCode installation #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TobiasDuswald wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add fatal for faulty XCode installation #353

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0cb684
Add fatal for faulty XCode installation (#352)
TobiasDuswald Nov 21, 2023
e8d1306
Add links to error message
TobiasDuswald Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmake/external/ROOT.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,18 @@ if(APPLE)
"${DETECTED_OS_VERS}" MATCHES "^osx-12" OR
"${DETECTED_OS_VERS}" MATCHES "^osx-11.6" OR
"${DETECTED_OS_VERS}" MATCHES "^osx-11.7")
# Test if Xcode is installed via `xcodebuild -version`.
message(STATUS "##### Checking if XCODE is installed")
execute_process(COMMAND bash "-c" "xcodebuild -version" ERROR_VARIABLE XCODE_ERROR)
if("${XCODE_ERROR}" STREQUAL "")
message(STATUS "##### XCODE is installed")
else()
message(FATAL_ERROR "##### XCODE is not installed correctly. Please install XCODE (and then the command line tools). Consult issue #352 and the documentation")
Comment thread
TobiasDuswald marked this conversation as resolved.
Outdated
endif()
# Determine XCDOE version
execute_process(COMMAND bash "-c" "xcodebuild -version | sed -En 's/Xcode[[:space:]]+([0-9\.]*)/\\1/p'" OUTPUT_VARIABLE XCODE_VERS)
message(STATUS "##### XCODE version: ${XCODE_VERS}")
# Set appropriate ROOT version depending on XCODE version
if("${XCODE_VERS}" GREATER_EQUAL "14.3")
message(STATUS "##### Using ROOT builds for XCODE 14.3")
set(ROOT_TAR_FILE root_v6.29.01_cxx14_python3.9_osx-xcode-14.3-${DETECTED_ARCH}.tar.gz)
Expand Down