Fix session delete duplication and undo refresh - #1737
Open
Rat0323 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pointerupandclickapp-server-manager-signals-*asset and request function instead of relying on a stale hashed module/exportWhy
A single delete activation could issue duplicate
/deleterequests. One request deleted the thread while the second reportedThread not found in local storage, leaving a stale row visible until restart.After undoing a deletion, the database and rollout file were restored, but an expanded Recent section did not update until it was collapsed and expanded again. The refresh helper referenced an old hashed Codex asset and export name, so the current desktop build never received the sidebar refresh signal.
User impact
Validation
cargo test -p codex-plus-core --test cdp_bridge— 97 passednpm test --prefix apps/codex-plus-manager— 36 passedcargo fmt --checkgit diff --checknpm run check --prefix apps/codex-plus-manageris currently blocked by the repository tsconfig using the removed TypeScriptbaseUrloption (TS5102), unrelated to this JavaScript/Rust-test-only change.