Fix provider-specific goals feature overrides - #1718
Open
Rat0323 wants to merge 2 commits into
Open
Conversation
Rat0323
marked this pull request as ready for review
July 31, 2026 05:35
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
goals = trueorgoals = falseoverride instead of disabling the checkbox when common configuration is present.[features]exists in both provider and common configuration.Why
The manager previously read the checkbox only from the provider-local TOML. Save normalization could remove a duplicated
features.goalsentry from the provider because it came from the common configuration, so reopening the editor showed an unchecked box even when the effective configuration enabled the feature. The old merge path also did not reliably preserve an explicit provider override over the common value.Validation
npm run testnpm run checknpm run vite:buildcargo fmtcargo test -p codex-plus-core merge_common_configcargo test -p codex-plus-manager normalize_settings_before_save