Skip to content

Add support for member locking - #2

Draft
BenyaminBen wants to merge 3 commits into
masterfrom
upstream-pr-3409
Draft

Add support for member locking#2
BenyaminBen wants to merge 3 commits into
masterfrom
upstream-pr-3409

Conversation

@BenyaminBen

@BenyaminBen BenyaminBen commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Closes #11
Closes #12

Mirror of PR#3409 (author: @SanjulaGanepola)


Changes

This PR adds support for member locking using a shared-update lock (*SHRUPD) that is allocated on reads and deallocated when we close the editor. This is an opt in setting meaning it is disabled by default.

This has been requested in Issue#1688 and Issue#2409

How to test this PR

  1. Debug the extension using this branch.
  2. Navigate to the connection settings and enable Member Locking under the Source Code tab.
  3. Open a member.
  4. Launch a separate VS Code window running the release version of Code4i.
  5. Attempt to open the same member in this new window and observe the member is locked.
  6. In the first window, disable the setting.
  7. In the second window, reattempt to open the member and observe that it can be opened.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You鈥檝e used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

鈿欙笍 Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0a899e75-741b-44ce-9f21-057d5785284b

馃摜 Commits

Reviewing files that changed from the base of the PR and between 0c786aa and a833dd7.

馃搾 Files selected for processing (6)
  • src/api/configuration/config/ConnectionManager.ts
  • src/api/configuration/config/types.ts
  • src/api/memberLocks.ts
  • src/api/tests/suites/memberLocks.test.ts
  • src/filesystems/qsys/QSysFs.ts
  • src/webviews/settings/index.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

@BenyaminBen

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
鈿狅笍 Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Member Lock Locking the source on the IBMi while editing in Code for IBM i

2 participants