Skip to content

Fix MFA support using additionalAuthenticationFactor JDBC option - #1

Draft
BenyaminBen wants to merge 1 commit into
masterfrom
upstream-pr-3412
Draft

Fix MFA support using additionalAuthenticationFactor JDBC option#1
BenyaminBen wants to merge 1 commit into
masterfrom
upstream-pr-3412

Conversation

@BenyaminBen

@BenyaminBen BenyaminBen commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Mirror of codefori#3412 (author: @SanjulaGanepola)


Changes

Previously Code4i <3.0.0 supported MFA for IBM i 7.6, but this broke after 3.0.0 with the introduction of mapepire. As mentioned [here], mapepire supports MFA by passing the additionalAuthenticationFactor JDBC option.

TODO:

  • Verify MFA works for mapepire in server mode
  • Verify MFA works for mapepire in single mode

How to test this PR

To be added

Checklist

  • have tested my change
  • have created one or more test cases

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You鈥檝e used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

鈿欙笍 Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cb272a45-d6ba-4fc3-bf33-fe8ed2345bc2

馃摜 Commits

Reviewing files that changed from the base of the PR and between 0c786aa and 9faf44d.

馃搾 Files selected for processing (1)
  • src/api/IBMi.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

@BenyaminBen

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
鈿狅笍 Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants