Skip to content

Playground: link AbortController + TextEncoder polyfills from JsRuntimeHost #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkaradzic-microsoft merged 3 commits into from
Jun 12, 2026
Merged

Playground: link AbortController + TextEncoder polyfills from JsRuntimeHost #1708

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6264dea
Playground: link AbortController polyfill + extend document shim
bkaradzic-microsoft Jun 1, 2026
5e2fec8
Playground: wire TextEncoder polyfill from JsRuntimeHost
bkaradzic-microsoft Jun 1, 2026
82e555a
Playground: round-trip serialization in-memory instead of DOM shim
bkaradzic-microsoft Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Apps/Playground/Android/BabylonNative/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ target_link_libraries(BabylonNativeJNI
PRIVATE EGL
PRIVATE log
PRIVATE -lz
PRIVATE AbortController
PRIVATE AndroidExtensions
PRIVATE AppRuntime
PRIVATE Blob
Expand All @@ -45,5 +46,6 @@ target_link_libraries(BabylonNativeJNI
PRIVATE ShaderCache
PRIVATE TestUtils
PRIVATE TextDecoder
PRIVATE TextEncoder
PRIVATE Window
PRIVATE XMLHttpRequest)
2 changes: 2 additions & 0 deletions Apps/Playground/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ endif()
target_include_directories(Playground PRIVATE ".")

target_link_libraries(Playground
PRIVATE AbortController
PRIVATE AppRuntime
PRIVATE Blob
PRIVATE bx
Expand All @@ -154,6 +155,7 @@ target_link_libraries(Playground
PRIVATE ShaderCache
PRIVATE TestUtils
PRIVATE TextDecoder
PRIVATE TextEncoder
PRIVATE Window
PRIVATE XMLHttpRequest
${ADDITIONAL_LIBRARIES}
Expand Down
2 changes: 0 additions & 2 deletions Apps/Playground/Scripts/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2258,8 +2258,6 @@
{
"title": "Serialize scene without materials",
"playgroundId": "#PH4DEZ#1",
"excludeFromAutomaticTesting": true,
Comment thread
bkaradzic-microsoft marked this conversation as resolved.
Resolved
"reason": "Pixel comparison fails (more than 20% pixels differ)",
"referenceImage": "serializeWithoutMaterials.png"
},
{
Expand Down
47 changes: 45 additions & 2 deletions Apps/Playground/Scripts/validation_native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,9 +525,52 @@
if (type === "canvas") {
return new OffscreenCanvas(64, 64);
}
return {};
// Generic element stub with a no-op dispatchEvent so serializer
// tests that simulate a click via createEvent/dispatchEvent run
// without throwing.
return {
style: {},
addEventListener: function () { },
removeEventListener: function () { },
dispatchEvent: function () { return true; },
appendChild: function (c) { return c; },
removeChild: function (c) { return c; },
setAttribute: function () { },
getAttribute: function () { return null; },
click: function () { },
};
},
createEvent: function (type) {
Comment thread
bkaradzic-microsoft marked this conversation as resolved.
Resolved
var ev = {
type: '',
bubbles: false,
cancelable: false,
defaultPrevented: false,
target: null,
currentTarget: null,
timeStamp: Date.now(),
detail: null,
preventDefault: function () { ev.defaultPrevented = true; },
stopPropagation: function () { },
stopImmediatePropagation: function () { },
};
ev.initEvent = function (t, bubbles, cancelable) {
ev.type = String(t || '');
ev.bubbles = !!bubbles;
ev.cancelable = !!cancelable;
};
ev.initCustomEvent = function (t, bubbles, cancelable, detail) {
ev.initEvent(t, bubbles, cancelable);
ev.detail = detail;
};
ev.initUIEvent = ev.initEvent;
ev.initMouseEvent = ev.initEvent;
return ev;
},
removeEventListener: function () { }
addEventListener: function () { },
removeEventListener: function () { },
dispatchEvent: function () { return true; },
body: { appendChild: function (c) { return c; }, removeChild: function (c) { return c; } },
}

const xhr = new XMLHttpRequest();
Expand Down
6 changes: 6 additions & 0 deletions Apps/Playground/Shared/AppContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@
#include <Babylon/Plugins/ShaderCache.h>
#include <Babylon/Plugins/TestUtils.h>

#include <Babylon/Polyfills/AbortController.h>
#include <Babylon/Polyfills/Blob.h>
#include <Babylon/Polyfills/Canvas.h>
#include <Babylon/Polyfills/Console.h>
#include <Babylon/Polyfills/File.h>
#include <Babylon/Polyfills/Performance.h>
#include <Babylon/Polyfills/TextDecoder.h>
#include <Babylon/Polyfills/TextEncoder.h>
#include <Babylon/Polyfills/Window.h>
#include <Babylon/Polyfills/XMLHttpRequest.h>

Expand Down Expand Up @@ -185,8 +187,12 @@ AppContext::AppContext(

Babylon::Polyfills::Window::Initialize(env);

Babylon::Polyfills::AbortController::Initialize(env);

Babylon::Polyfills::TextDecoder::Initialize(env);

Babylon::Polyfills::TextEncoder::Initialize(env);

Babylon::Polyfills::XMLHttpRequest::Initialize(env);
m_canvas.emplace(Babylon::Polyfills::Canvas::Initialize(env));

Expand Down
Loading