fix: 채팅방 목록 조회 시 닉네임 미설정 상대방 nickname null 응답 수정

[dnjswldnd-3513]

🔍 개요
채팅방 목록 조회 API에서 닉네임 미설정 사용자가 상대방인 경우
counterpartNickname이 null로 응답되는 버그를 수정합니다.

close #2416

🚀 주요 변경 내용

• TeamRecruitmentChatRoomListItemResponse: counterpart.getNickname() → getDisplayNickname()

💬 참고 사항
PR #2413에서 동일 패턴 수정 이력 존재 (getChatRooms에서만 누락된 케이스)

✅ Checklist (완료 조건)

• 코드 스타일 가이드 준수
• 테스트 코드 포함됨
• Reviewers / Assignees / Labels 지정 완료
• 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

• Bug Fixes
  • Direct team recruitment chat rooms now consistently display the counterpart’s user-facing nickname in the room name and participant information.
  • Chat rooms involving users without a registered nickname now show an appropriate anonymous display name instead of leaving the information blank.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f59f62ab-228f-4543-b9d6-610ba2719d49

📥 Commits

Reviewing files that changed from the base of the PR and between ee04a63 and 1987595.

📒 Files selected for processing (2)

• src/main/java/in/koreatech/koin/domain/teamrecruitment/dto/TeamRecruitmentChatRoomListItemResponse.java
• src/test/java/in/koreatech/koin/unit/domain/teamrecruitment/service/TeamRecruitmentChatServiceTest.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Direct chat room responses now use getDisplayNickname() for room names and counterpart nicknames. Tests cover counterparts without configured nicknames.

Changes

Team recruitment chat room responses

Layer / File(s)	Summary
Direct chat display nickname handling src/main/java/in/koreatech/koin/domain/teamrecruitment/dto/TeamRecruitmentChatRoomListItemResponse.java, src/test/java/in/koreatech/koin/unit/domain/teamrecruitment/service/TeamRecruitmentChatServiceTest.java	Direct chat rooms now use the counterpart display nickname for roomName and counterpartNickname. Tests verify the fallback value is non-null when the counterpart has no nickname.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to fa5fe

Direct chat room lists now return a fallback display nickname when the counterpart has not configured a nickname, with coverage for that case. No current merge-blocking risk remains.

Suggested reviewers: taejinn

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the fix for null nickname responses when the chat counterpart has not set a nickname.
Linked Issues check	✅ Passed	The implementation replaces getNickname() with getDisplayNickname() for direct chat room names and counterpart nicknames. The tests verify fallback output for users without a nickname. This satisfies …
Out of Scope Changes check	✅ Passed	All changes support issue #2416. The production change fixes the fallback nickname, and the test changes verify the corrected behavior.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/2416-chat-room-counterpart-nickname-null

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Unit Test Results

1 149 tests   1 146 ✔️  2m 38s ⏱️
   258 suites         3 💤
   258 files           0 ❌

Results for commit fa5fe33.

♻️ This comment has been updated with latest results.