Skip to content

fix: OpenAPI 응답 코드를 표준 status와 204 no-content로 정규화 - #2390

Merged
taejinn merged 1 commit into
developfrom
fix/2377-openapi-response-normalization
Sep 2, 2026
Merged

fix: OpenAPI 응답 코드를 표준 status와 204 no-content로 정규화#2390
taejinn merged 1 commit into
developfrom
fix/2377-openapi-response-normalization

Conversation

@taejinn

@taejinn taejinn commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

🔍 개요

  • 런타임 OpenAPI 응답 구조를 표준 HTTP status key와 no-content 표현으로 정규화합니다.

🚀 주요 변경 내용

  • 1) 400, 2) 400 형태를 표준 400 key 하나로 그룹화합니다.
  • 같은 status의 domain error code를 named examples로 병합합니다.
  • 기존 success/error schema, description, example을 보존합니다.
  • 잘못 생성되던 phantom 200을 제거합니다.
  • 204Void success response의 content를 제거합니다.

💬 참고 사항

  • 영향
    • 심각도는 P1 OpenAPI·SDK 계약 오류이며 클라이언트 validator와 SDK 생성기가 표준 response 구조를 읽습니다.
    • endpoint payload와 업무 흐름을 유지하며 OpenAPI 생성 결과를 정렬합니다.
  • 검증
    • ApiResponseCodesOperationCustomizerTest 8개와 CampusOpenApiContractTest 2개가 통과했습니다.
    • root list schema, 201, 204, error examples 보존을 확인했습니다.
  • 반영 순서
    • #2404를 먼저 반영하고 이 PR을 적용한 뒤 #2391을 최신 develop에 rebase합니다.

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

@taejinn taejinn added 버그 정상적으로 동작하지 않는 문제상황입니다. 공통 백엔드 공통으로 작업할 이슈입니다. labels Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 52b3d60b-25cb-4d00-9a96-b5f6f50da6bc

📥 Commits

Reviewing files that changed from the base of the PR and between e447c44 and 0b00f13.

📒 Files selected for processing (3)
  • src/main/java/in/koreatech/koin/global/code/ApiResponseCodesOperationCustomizer.java
  • src/test/java/in/koreatech/koin/acceptance/domain/CampusOpenApiContractTest.java
  • src/test/java/in/koreatech/koin/unit/global/code/ApiResponseCodesOperationCustomizerTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

Unit Test Results

1 130 tests   1 127 ✔️  4m 32s ⏱️
   253 suites         3 💤
   253 files           0

Results for commit 0b00f13.

♻️ This comment has been updated with latest results.

@taejinn
taejinn force-pushed the fix/2377-openapi-response-normalization branch from 8f05e95 to 097d7d5 Compare September 2, 2026 11:28
@taejinn
taejinn marked this pull request as ready for review September 2, 2026 12:58
@github-actions
github-actions Bot requested review from ImTotem and dh2906 September 2, 2026 12:59
@taejinn
taejinn requested review from dnjswldnd-3513 and insik03 and removed request for ImTotem and dh2906 September 2, 2026 13:03
@taejinn
taejinn force-pushed the fix/2377-openapi-response-normalization branch from 097d7d5 to 0b00f13 Compare September 2, 2026 15:51
@taejinn
taejinn merged commit e77f271 into develop Sep 2, 2026
6 checks passed
@taejinn
taejinn deleted the fix/2377-openapi-response-normalization branch September 2, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

공통 백엔드 공통으로 작업할 이슈입니다. 버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[공통] 런타임 OpenAPI 응답 키와 204 응답 구조가 표준에 맞지 않음

2 participants