Improve the error for nested getSecret() calls in parameter files#20066
Open
polatengin wants to merge 8 commits into
Conversation
Contributor
|
Test this change out locally with the following install scripts (Action run 29541446351) VSCode
Azure CLI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19934
ARM supports Key Vault references as complete parameter values. It does not support them inside objects or arrays.
This change detects nested
getSecret()calls earlier and reportsBCP351error.Top-level
getSecret()assignments and supported extension configuration assignments continue to work.I've added tests for
getSecret()calls;az.getSecret()callsBefore the fix, all new tests failed with
BCP338, after the fix, they pass and reportBCP351as expected.The existing parameter-file and extension configuration tests also pass.
Checklist