Fix external inputs breaking base parameter spreads#20062
Open
polatengin wants to merge 7 commits into
Open
Conversation
…d parent parameter
Contributor
|
Test this change out locally with the following install scripts (Action run 29442789778) VSCode
Azure CLI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19954.
When a parent parameter file contains an
externalInput, using the spread operator with another inherited parameter could fail withBCP338.In this PR;
I've added tests that reproduce the issue with
...base.BI've fixed the issue in
ExpressionBuilderby evaluating only the selected base parameterI've also added coverage for object and array spreads, property access, bracket access, and nested parameter files
Checklist
Microsoft Reviewers: Open in CodeFlow