Add MS Rust toolchain CI leg - #5020
Draft
Daniel Jurek (danieljurek) wants to merge 7 commits into
Draft
Conversation
ci.tests.yml splices its Matrix parameter directly into a `$[ ... ]`
runtime expression and into `ne(<Matrix>, '{}')`. Passing a JSON object
literal produced invalid expression syntax and blocked the pipeline from
queueing at all.
Pass an expression fragment instead: `format()` builds the single-leg
matrix JSON at runtime, with LINUXVMIMAGE/LINUXPOOL resolved via
`variables[...]` so no nested macro expansion is required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e0f28e95-2c6c-4e82-a025-b6a8dd2e1f3e
msrustup resolves `components` strictly as host components and fails with US.host_component_not_found for 'rust-std', which it treats as a target-scoped component instead. The host std library already ships with the toolchain, so the entry was redundant as well as fatal. The root rust-toolchain.toml keeps rust-std since plain rustup accepts it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e0f28e95-2c6c-4e82-a025-b6a8dd2e1f3e
msrustup installs MS Rust toolchains outside rustup's registry, so rustup cannot resolve the custom 'ms-prod-1.95' channel from rust-toolchain.toml and every rustup call from the repo root fails. Let RUSTUP_EXE name the tool to query, defaulting to rustup so existing jobs are unaffected, and set it to msrustup as a matrix variable on the MS Rust leg. Matrix keys become job variables, so this needs no change to ci.tests.yml. Also skip msrustup's leading INFO lines when parsing the active toolchain, and check for an empty result before trimming rather than after. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e0f28e95-2c6c-4e82-a025-b6a8dd2e1f3e
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add msrust job