-
Notifications
You must be signed in to change notification settings - Fork 363
Cosmos: Implement Binary Round-Trip Fuzzer #4898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Debdatta Kunda (kundadebdatta)
wants to merge
26
commits into
main
from
users/kundadebdatta/4864_build_binary_round_trip_fuzzer
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
67b0ea0
cosmos(driver): add RFC-style binary-encoding wire-format spec and a …
d30b22a
test(cosmos): add corpus-shape samplers, size-scale knob, and reserve…
510aef0
ci(cosmos): run binary-JSON codec fuzzing as a non-blocking Linux/nig…
eb13279
ci(cosmos): trim weekly fuzz budget to fit the 90-min cap and rename …
7c4fd77
docs(cosmos): use absolute GitHub URLs for internal doc links
5952688
test(cosmos): expand binary-JSON golden vectors to cover all decodabl…
083f2c5
fix(cosmos): gate account-metadata failover test on emulator category…
1223cb9
test(cosmos): move binary round-trip fuzzer into azure_data_cosmos so…
44a1623
ci(cosmos): run the binary round-trip fuzzer on a live binary_encodin…
b59f2fa
ci(cosmos): gate the byte-level cargo-fuzz leg to the weekly pipeline
0b80524
docs(cosmos): fix round-trip fuzzer link after move to azure_data_cosmos
b54e0c4
ci(cosmos): give the two binary-fuzz legs distinct, meaningful job names
a16c950
ci(cosmos): run golden-vector validation in the Build stage only, not…
7475ab6
test(cosmos): raise default round-trip fuzzer SHAPE_RATIO to 85
9e2eb33
Cosmos: fix binary encoding round-trip test for large u64
0fc8d22
test(cosmos): retry transient errors in round-trip fuzzer and pin it …
04c4620
test(cosmos): fuzz true u64/wide floats, fail-fast on bad seed, robus…
cdcfeab
Merge branch 'main' into users/kundadebdatta/4864_build_binary_round_…
6639ad8
Merge branch 'main' into users/kundadebdatta/4864_build_binary_round_…
kundadebdatta 320b4b1
test(cosmos): normalize i64 >= 2^53 as lossy double token in fuzzer o…
c9d112a
Merge branch 'main' into users/kundadebdatta/4864_build_binary_round_…
kundadebdatta 69d76ad
test(cosmos): address Copilot PR review feedback on binary round-trip…
b265809
test(cosmos): fix fuzzer harness reproducibility, ASCII-key filtering…
ab51324
docs(cosmos): address remaining Copilot doc feedback on binary fuzzer…
42bb226
test(cosmos): use non-dictionary non-ASCII strings in unicode-off tes…
9d3261d
test(cosmos): harden binary round-trip fuzzer oracle and retry semantics
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,13 @@ azure_data_cosmos_driver = { path = "../azure_data_cosmos_driver", default-featu | |
| ] } | ||
| azure_identity.workspace = true | ||
| clap.workspace = true | ||
| # Test-only deps for the binary round-trip fuzzer | ||
| # (tests/binary_roundtrip_fuzzer.rs): it generates arbitrary JSON, canonicalizes | ||
| # it (RFC 8785), and hashes the canonical form for differential comparison. | ||
|
Comment on lines
+55
to
+57
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary comment IMO |
||
| arbitrary = { workspace = true } | ||
| arbitrary-json = { workspace = true } | ||
| json-canon = { workspace = true } | ||
| sha2 = { workspace = true } | ||
| # Enabled here (dev-only) so the metrics and tracing handler tests can drive | ||
| # in-memory OpenTelemetry exporters. `testing` provides `InMemoryMetricExporter` | ||
| # and `InMemorySpanExporter`. | ||
|
|
@@ -144,6 +151,11 @@ name = "binary_encoding" | |
| path = "tests/binary_encoding.rs" | ||
| required-features = ["key_auth", "control_plane", "fault_injection"] | ||
|
|
||
| [[test]] | ||
| name = "binary_roundtrip_fuzzer" | ||
| path = "tests/binary_roundtrip_fuzzer.rs" | ||
| required-features = ["key_auth", "control_plane", "fault_injection"] | ||
|
|
||
| [[test]] | ||
| name = "gateway_v2" | ||
| path = "tests/gateway_v2.rs" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a blurb to
/CONTRIBUTING.mdabout fuzz testing and usingarbitrary- even just a "Fuzzing" subheading under "Testing" and recommending use ofarbitrarywith a link to https://docs.rs/arbitrary would be fine. I want to avoid a situation where people keep adding similar but disparate dependencies for what should be shared. Or if you have more that you think other should use, just a brief write-up. Doesn't have to be extensive.