Repository navigation
Reject starts for disabled orchestrators #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4296ae9
Reject starts for disabled orchestrators
YunchuWang dc40adb
Validate disabled orchestrators at start boundaries
YunchuWang b1e39c0
Cover restart and external client targets
YunchuWang b724942
Match task hub names case-insensitively
YunchuWang 3b28148
Clarify current-app availability checks
YunchuWang abecce5
Preserve starts for unknown orchestrators
YunchuWang 9c1cf7d
Merge branch 'dev' into fix-1933-disabled-orchestrator
YunchuWang a455865
Fix disabled orchestrator start validation
YunchuWang 868499c
Revert "Fix disabled orchestrator start validation"
YunchuWang b9bd56a
Use provider-specific task hub casing
YunchuWang 32a2a3f
Add disabled orchestrator E2E coverage
YunchuWang 990df36
Cover cross-connection client targeting
YunchuWang 983aa4d
Merge branch 'dev' into fix-1933-disabled-orchestrator
YunchuWang 5f97425
Scope disabled orchestrator validation
YunchuWang bb01c35
Merge branch 'dev' into fix-1933-disabled-orchestrator
YunchuWang 7804b3e
Reuse legacy current-app validation gate
YunchuWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/WebJobs.Extensions.DurableTask/Exceptions/OrchestratorFunctionUnavailableException.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
|
||
| using System; | ||
|
|
||
| namespace Microsoft.Azure.WebJobs.Extensions.DurableTask | ||
| { | ||
| internal sealed class OrchestratorFunctionUnavailableException : ArgumentException | ||
| { | ||
| internal OrchestratorFunctionUnavailableException(string message) | ||
| : base(message) | ||
| { | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.