You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add FailureDetailsProvider E2E Test for Node - #3463
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds end-to-end coverage for surfacing custom exception properties into FailureDetails.Properties when running Durable Functions with the Node (JavaScript) SDK, including a nested orchestration scenario to validate InnerFailure propagation.
Changes:
Enables the existing custom-exception-properties FailureDetails test for Node (and adds Node-specific assertions for JSON/protobuf type differences).
Adds a BasicNode function implementation that registers an ExceptionPropertiesProvider and throws a custom exception carrying structured properties.
Updates the BasicNode AzureManaged extension package reference.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File
Description
test/e2e/Tests/Tests/ErrorHandlingTests.cs
Runs FailureDetails custom-properties validation for Node and adds a new nested FailureDetails propagation E2E test.
Use the SDK release that includes custom exception properties support required by the Node E2E tests.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Node-specific DateTime assertion uses Convert.ToDateTime(...), which is culture-sensitive and can become flaky depending on the test runner culture/format settings. Since the value is an ISO-8601 string from the JS SDK, parse it using invariant culture and assume/adjust to UTC.
// Verify DateTime property (sent as ISO-8601 string by the JS SDK)
Assert.True(failureDetails.Properties.ContainsKey("DateTimeProperty"));
Assert.Equal(
new DateTime(2025, 10, 15, 14, 30, 0, DateTimeKind.Utc),
Convert.ToDateTime(failureDetails.Properties["DateTimeProperty"]).ToUniversalTime());
The value used for LongProperty (999999999) is still within the 32-bit integer range, so this scenario doesn’t actually validate that a 64-bit value round-trips correctly (or that int vs long differences are handled). Consider using a value > int.MaxValue but < 2^53 (e.g., 3000000000) and updating the corresponding C# assertions to strengthen the test signal.
This hunk removes the existing DTS exclusion, so the test is now scheduled in the DTS backend lane (language-e2e.yml:171-215) even though the removed comment records that DTS did not support FailureDetails properties. This PR only adds the Node provider and does not add a DTS capability change, so the new Node assertions can fail there instead of validating the intended Node path. Keep the DTS skip until that backend support is available (or add the corresponding backend change).
The new nested test is also selected for the DTS backend, but unlike the existing FailureDetails test it has no DTS exclusion. That schedules a second scenario against the backend that the surrounding test matrix previously documented as unsupported; add the backend skip (or only remove it once DTS support is confirmed) so this Node-only test does not fail in the DTS lane for an unrelated reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2e test for custom exception provider for Node