-
Notifications
You must be signed in to change notification settings - Fork 352
feat(azure.ai.agents): add invocationsModeration to RAI policies #9596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Amit Bhave (amitbhave10)
wants to merge
6
commits into
Azure:main
Choose a base branch
from
amitbhave10:amitbhave/agents-invocations-moderation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
563931e
feat(agents): add invocationsModeration to RAI policies
Amitbhave af5c48d
fix(agents): address multi-model review of invocationsModeration
Amitbhave a594358
docs(agents): link the changelog entry to PR #9596
Amitbhave 34e1714
fix(agents): reword to satisfy the repo spell check
Amitbhave 5144722
fix(agents): address Copilot review on invocationsModeration
Amitbhave 478cb5d
fix(agents): validate invocationsModeration on inline camelCase defin…
Amitbhave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the first named
rai_policyis mapped intorai_config. A later policy's validinvocationsModerationpasses validation but is silently ignored. Could we define how multiple RAI policies should be handled?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid —
mapRaiConfigreturns on the firstrai_policymatch. That first-match-wins behaviour predates this PR, but it becomes a correctness gap now that validation loops over every policy: a secondrai_policycarrying aninvocationsModerationblock would validate cleanly and then be discarded by the mapper, so the user would get no guardrail with no warning.rai_configis a single object on the wire, so more than onerai_policyisn't expressible. Rather than change the mapper's precedence (any choice there is arbitrary and still drops user intent), 478cb5d rejects the ambiguity up front:Consistent with the rest of this PR's fail-fast-locally approach. Covered by
TestValidateAgentDefinition_SingleRaiPolicyandTestAgentPoliciesSingleRaiPolicyInline. Confirmed no existing test, testdata file, or README example declares tworai_policyentries in one list, so this is not a breaking change in practice.Happy to narrow it to "only reject when a second policy carries
invocationsModeration" if you'd prefer the softer rule — just say the word.