Add azd ai dataset extension for Foundry datasets

[Mohamed Hessien (m7md7sien)]

Adds azd ai dataset ΓÇö a standalone extension for registering and versioning Foundry datasets.

Why its own extension

A dataset is a general Foundry asset. Fine-tuning and other scenarios need one as much as evaluation does, so the CRUD group does not belong inside the evaluation extension. This extension has its own Go module, lint workflow and release pipeline, and no dependency on azure.ai.evaluations.

The line drawn with the evaluation extension: CRUD moved, generation stayed. generate writes the datasets: entry into the evaluation configuration, so moving it would strand a config write across an extension boundary ΓÇö a generated dataset registered with the service and absent from configuration, which azd up would not reconcile. create/update/list/show/delete/versions need no configuration at all, which is why they could move.

Surface

azd ai dataset create <name>      register a dataset, publishing version 1
azd ai dataset update <name>      publish a new version
azd ai dataset list               list the project's datasets
azd ai dataset show <name>        show a version
azd ai dataset delete <name>      delete a version
azd ai dataset versions list <name>

Notable

• Every user-facing string lives in one file (internal/messages/messages.go) so the whole voice of the CLI can be reviewed in one sitting. 69 messages.
• TYPE, not FORMAT. The API accepts format on upload and never returns it, so the previous column was blank for every dataset ever listed.
• Identity fixed. Carved from the evaluation extension, it had inherited its User-Agent (azd-ext-azure-ai-evaluations) and debug log name (azd-ai-eval-*.log), so a dataset request could not be told from an eval one in a service log or a local one.
• Auth errors say what to do. A credential that cannot mint a token fails before any 401 and surfaced as a bare SDK error. It now suggests retrying first and logging in second ΓÇö observed failing transiently against a login that was valid.
• A name the service will reject is refused locally. A dataset name with a space came back as a 400 wrapped in four levels of nested JSON; it is now checked against the accepted character set before the request.
• A UTF-8 BOM no longer corrupts an upload. Windows editors and PowerShell write one by default, and it was being uploaded into the first row's first key rather than skipped.
• Nil-guarded the endpoint resolution cascade and closed the azd client on the error paths that abandoned it.

Verified

go build, go vet -tags live,hero, go test ./... and gofmt clean. Exercised live against a Foundry project: create ΓåÆ 1.0, update ΓåÆ 2.0, versions list, show, list, and published to a local registry for a bug bash through real azd.

Not included, deliberately

No registry.json entry and no microsoft.foundry bundle dependency. Both need published artifacts; listing an unpublished extension in the bundle breaks azd extension install microsoft.foundry for everyone. Those land after the first release.

Open question for reviewers

azd ai dataset versions list <unknown-name> errors and exits 1 here, while the same command in the evaluation extension (#9500) lists nothing and exits 0. I tried making the eval side match this one and it broke two tests whose names are the argument against it ΓÇö "an unknown name lists nothing rather than failing" and "deleting an unregistered dataset is idempotent, not an error", the second because delete idempotence is verified by listing what is left.

A list is a filter rather than a lookup, so empty-and-successful is defensible and -o json callers range over the array instead of branching on an error. By that reasoning this extension's versions list is the one that should move. dataset show on an unknown name is not in question: that one is a lookup and should fail, as it does.

Draft ΓÇö not requesting reviewers yet.

Fixes #9550

[azure-pipelines]

Azure Pipelines:
7 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[azure-pipelines]

Azure Pipelines:
7 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Adds a standalone Foundry dataset extension with CRUD/versioning commands, API clients, tests, documentation, and release automation.

Changes:

• Adds dataset creation, updates, listing, inspection, deletion, and version listing.
• Adds endpoint resolution, validation, structured errors, and JSON/table output.
• Adds unit/live tests plus build, lint, and release infrastructure.

Reviewed changes

Copilot reviewed 49 out of 50 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
eng/pipelines/release-ext-azure-ai-dataset.yml	Adds extension release pipeline.
cli/azd/extensions/azure.ai.dataset/version.txt	Sets initial beta version.
cli/azd/extensions/azure.ai.dataset/tests/cli/harness_test.go	Adds live CLI harness.
cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go	Tests dataset CLI workflows.
cli/azd/extensions/azure.ai.dataset/README.md	Documents installation and commands.
cli/azd/extensions/azure.ai.dataset/main.go	Adds extension entry point.
cli/azd/extensions/azure.ai.dataset/internal/version/version.go	Defines build metadata.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/version_test.go	Tests version handling.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/uri_test.go	Tests URI resolution.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/upload_version_test.go	Tests conflict-aware uploads.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go	Implements dataset and storage operations.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations_wire_test.go	Tests API request contracts.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go	Defines API models and file handling.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/list.go	Implements listing and version ordering.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/download_wire_test.go	Tests download HTTP behavior.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/download_test.go	Tests blob selection logic.
cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/bom_test.go	Tests BOM and file handling.
cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go	Centralizes user-facing messages.
cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/validator.go	Validates Foundry endpoints.
cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/types.go	Defines endpoint-resolution types.
cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/store.go	Reads shared project context.
cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go	Implements endpoint precedence.
cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver_test.go	Tests endpoint resolution.
cli/azd/extensions/azure.ai.dataset/internal/exterrors/errors.go	Adds structured error helpers.
cli/azd/extensions/azure.ai.dataset/internal/exterrors/codes.go	Defines structured error codes.
cli/azd/extensions/azure.ai.dataset/internal/cmd/table_test.go	Tests table rendering.
cli/azd/extensions/azure.ai.dataset/internal/cmd/surface_test.go	Tests command surface and flags.
cli/azd/extensions/azure.ai.dataset/internal/cmd/root.go	Builds the command tree.
cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go	Implements JSON and text output.
cli/azd/extensions/azure.ai.dataset/internal/cmd/output_test.go	Tests output formatting.
cli/azd/extensions/azure.ai.dataset/internal/cmd/names.go	Validates dataset names.
cli/azd/extensions/azure.ai.dataset/internal/cmd/names_test.go	Tests naming constraints.
cli/azd/extensions/azure.ai.dataset/internal/cmd/helpers_test.go	Tests command helpers.
cli/azd/extensions/azure.ai.dataset/internal/cmd/debug.go	Configures debug logging.
cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go	Implements dataset commands.
cli/azd/extensions/azure.ai.dataset/internal/cmd/context.go	Creates command service context.
cli/azd/extensions/azure.ai.dataset/internal/cmd/artifacts.go	Defines persistence helpers.
cli/azd/extensions/azure.ai.dataset/internal/cmd/apiversions.go	Defines service API versions.
cli/azd/extensions/azure.ai.dataset/go.mod	Defines the Go module.
cli/azd/extensions/azure.ai.dataset/extension.yaml	Declares extension metadata.
cli/azd/extensions/azure.ai.dataset/cspell.yaml	Configures spell checking.
cli/azd/extensions/azure.ai.dataset/ci-test.ps1	Adds CI test execution.
cli/azd/extensions/azure.ai.dataset/ci-build.ps1	Adds CI binary builds.
cli/azd/extensions/azure.ai.dataset/CHANGELOG.md	Records the initial release.
cli/azd/extensions/azure.ai.dataset/build.sh	Adds Unix cross-platform builds.
cli/azd/extensions/azure.ai.dataset/build.ps1	Adds Windows cross-platform builds.
cli/azd/extensions/azure.ai.dataset/.golangci.yaml	Configures Go linting.
cli/azd/extensions/azure.ai.dataset/.gitignore	Ignores generated artifacts.
.github/workflows/lint-ext-azure-ai-dataset.yml	Adds GitHub lint workflow.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 60 out of 61 changed files in this pull request and generated no new comments.

Suppressed comments (9)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:374

• This reverses the documented and tested idempotence guarantee: when the service returns 404 for an already-absent version, delete exits nonzero. Treat not-found as an already-completed delete and continue to the normal human/JSON success response. [azd-code-reviewer]

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)

cli/azd/extensions/azure.ai.dataset/README.md:41

• The documented cascade omits both the persisted azd ai project set value and the AZURE_AI_PROJECT_ENDPOINT fallback, so users may troubleshoot or override the wrong source. Document all four implemented levels in their actual precedence order. [azd-code-reviewer]

Every command resolves the Foundry project endpoint in this order:

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:243

• The advertised empty-and-success behavior does not handle the API's 404 form for an unknown dataset. TestUploadNextVersionTreatsAnUnknownDatasetAsVersionless explicitly models /versions returning 404, but this command returns that error instead of []. Normalize only not-found here and keep propagating other failures. [azd-code-reviewer]

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/README.md:22

• This usage is incomplete: the implementation requires --version, so copying the documented command always fails before deletion. Include the required flag in the command table. [azd-code-reviewer]

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:139

• This extension newly reads AZURE_AI_PROJECT_ENDPOINT, but that variable is absent from cli/azd/docs/environment-variables.md, and the existing FOUNDRY_PROJECT_ENDPOINT entry still says it is agents-only. Update the environment-variable reference so this fallback is discoverable and its precedence is accurate. [azd-code-reviewer]
  cli/azd/extensions/azure.ai.dataset/tests/cli/harness_test.go:130
• This test harness cannot actually detect the hang asserted by TestCLIRequiredValuesFailInsteadOfHanging: exec.Command has no deadline, so a regression blocks until the entire go test timeout. Run subprocesses with exec.CommandContext and a short per-command timeout, and fail with the captured output when it expires. [azd-code-reviewer]
  cli/azd/extensions/azure.ai.dataset/CHANGELOG.md:17
• The release note claims a user-visible read-back feature, but no command calls DownloadDatasetContent; only tests do, and the package is internal to this module. Either expose the claimed capability through the CLI or remove it from the release notes. [azd-code-reviewer]

- Reads dataset content back, whether the service hands out a blob URI or the
  container holding it.

cli/azd/extensions/azure.ai.dataset/.golangci.yaml:12

• The repository's Go guidance sets lll to 125 characters (cli/azd/AGENTS.md:97-108), but this module allows 220, so its dedicated CI accepts lines the repository standard rejects. Restore the 125-character limit and wrap the existing overlong source line. [azd-code-reviewer]

      line-length: 220

cli/azd/extensions/azure.ai.dataset/internal/cmd/surface_test.go:245

• Remove the accidental // embedded in this sentence and wrap it to the repository's 125-character limit. [azd-code-reviewer]

// A message pointing at `azd ai eval dataset ...` is almost always the copy// these commands came from rather than a deliberate cross-extension pointer.

[Copilot]

Pull request overview

Copilot reviewed 61 out of 62 changed files in this pull request and generated no new comments.

Suppressed comments (8)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:375

• [azd-code-reviewer] This explicitly turns a not-found delete into failure, while TestCLIDeleteIsIdempotent defines deleting an unregistered version as successful. Treat 404 as an idempotent success so cleanup scripts do not fail when the version is already absent.

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:99

• [azd-code-reviewer] A non-404 listing failure leaves exists=false, the probes ignore their errors, and create is then allowed to continue. If the transient failure clears when UploadNextVersion lists again, create can publish a new version of an existing dataset instead of failing as already-exists. Propagate an inconclusive list error for create.

			if err := checkAssetExistence(
				verb, "dataset", name, exists, dataset_api.IsNotFound(listErr),
			); err != nil {

cli/azd/extensions/azure.ai.dataset/README.md:41

• [azd-code-reviewer] This omits two implemented resolution levels: AZURE_AI_PROJECT_ENDPOINT is a fallback at both environment levels, and persisted azd ai project set context is checked before host variables. Users following this order can diagnose or update the wrong source. Document the actual four-level cascade.

Every command resolves the Foundry project endpoint in this order:

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/internal/cmd/root.go:16

• [azd-code-reviewer] The inherited --environment/AZD_ENVIRONMENT value is discarded here. Both endpoint resolution and version persistence call Environment().GetCurrent(), which resolves the project's default environment, so -e staging can target the default Foundry project and write EVAL_DATASET_VERSION into the wrong environment. Thread extCtx.Environment through the context/resolver and use the named environment when it is set.

	rootCmd, _ := azdext.NewExtensionRootCommand(azdext.ExtensionCommandOptions{

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:243

• [azd-code-reviewer] A 404 still returns an error here, contradicting the new command contract and the live tests that require an unknown name to produce an empty successful list. Normalize IsNotFound(err) to an empty DatasetList; otherwise versions list <unknown> still exits 1 on services that report absence with 404.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:34

• [azd-code-reviewer] Unsupported output values are silently treated as human/table output because only json is recognized. For example, -o yaml exits successfully with non-YAML text, which can break automation. Register per-command output options with the extension SDK (for example json and table) so unsupported values fail validation.

	return strings.ToLower(v)
}

// isJSON reports whether the command should emit machine-readable output.
func isJSON(cmd *cobra.Command) bool {
	return outputFormat(cmd) == outputJSON

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:357

• [azd-code-reviewer] This message always claims --no-prompt is active, but requireFlag is also called during ordinary interactive invocations such as dataset delete <name>. The resulting error is factually wrong; either prompt when allowed or use a mode-neutral required-flag message.
  cli/azd/extensions/azure.ai.dataset/README.md:22
• [azd-code-reviewer] The documented delete invocation always fails because the implementation requires --version. Include the required flag so the command table is directly runnable.

| `azd ai dataset delete <name>` | Delete a dataset version |

[Copilot]

Pull request overview

Copilot reviewed 61 out of 62 changed files in this pull request and generated no new comments.

Suppressed comments (7)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:376

• A 404 currently becomes DatasetVersionNotFound, so deleting an already-absent version exits non-zero. This directly contradicts the added idempotence test. Treat not-found as successful deletion and only return other service failures. (azd-code-reviewer)

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}
				return messages.DeletingDatasetVersion(name, version, err)

cli/azd/extensions/azure.ai.dataset/README.md:42

• The documented cascade omits two implemented sources: persisted azd ai project set context and the AZURE_AI_PROJECT_ENDPOINT fallback at both environment levels. Users can therefore get an endpoint they did not expect without the README explaining its precedence. Document all four levels in resolver order. (azd-code-reviewer)

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:249

• An unknown dataset is returned as HTTP 404 by this API, so this branch currently exits with an error even though the new CLI tests require versions list to succeed with an empty array. Normalize a not-found response to an empty DatasetList; preserve other failures. (azd-code-reviewer)

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:309

• The API can return 404 for this version listing, but this path wraps it as a raw “resolving latest version” failure. That contradicts TestCLIUnknownDatasetIsBrief, which expects the same concise DatasetNotFound result used for an empty listing. Translate not-found before wrapping other errors. (azd-code-reviewer)

				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
				if err != nil {
					return messages.ResolvingLatestDatasetVersion(name, err)

cli/azd/extensions/azure.ai.dataset/README.md:22

• This documented invocation always fails because delete requires --version. Include the required flag so the command table is executable as written. (azd-code-reviewer)

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:44

• These transport aliases are serialized directly by every -o json path. A response using data_uri therefore emits data_uri, while a response using dataUri emits dataUri, so scripts receive different schemas for the same field. Map Dataset to a stable CLI output type that always exposes one resolved dataUri field. (azd-code-reviewer)
  cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:51
• Cleanup silently returns when listing or JSON decoding fails and ignores every delete exit code, so the live suite can pass while leaving datasets behind. Make cleanup failures fail the test instead of swallowing them. (azd-code-reviewer)

[Copilot]

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated no new comments.

Suppressed comments (8)

cli/azd/extensions/azure.ai.dataset/internal/cmd/root.go:45

• [azd-code-reviewer] None of the leaf commands registers its supported --output values, so the SDK neither validates the flag nor publishes valid values in command metadata; for example, -o jsno silently falls back to human output. Register output options on each executable command, as in azure.ai.projects/internal/cmd/project_show.go:59-63; the SDK contract is documented in pkg/azdext/extension_command.go:250-260.

	rootCmd.AddCommand(

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:243

• [azd-code-reviewer] This still returns an error when the service represents an unknown dataset with 404, contradicting the documented empty-success behavior and TestCLIVersionsListOfAnUnknownNameSucceeds. Convert only a not-found response into an empty list; preserve other failures.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:377

• [azd-code-reviewer] Returning DatasetVersionNotFound makes deletion non-idempotent, while the PR's intended contract and TestCLIDeleteIsIdempotent require a missing version to succeed. Ignore only 404 and continue to the normal success output; keep surfacing all other failures.

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:357

• [azd-code-reviewer] This message always claims --no-prompt is active, but both create and delete call it whenever a required flag is absent, including ordinary interactive invocations. Remove the mode claim unless the caller actually checked that flag.
  cli/azd/extensions/azure.ai.dataset/README.md:22
• [azd-code-reviewer] This documented command always fails because delete requires --version. Include the required flag so the command table is executable as written.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/README.md:41

• [azd-code-reviewer] The documented resolution order omits two implemented sources: the AZURE_AI_PROJECT_ENDPOINT fallback at both environment levels and the persisted global project context between them. Users debugging why a flagless command selected an endpoint would get the wrong precedence from this section.

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/CHANGELOG.md:17

• [azd-code-reviewer] No command exposes content download and DownloadDatasetContent has no production caller, so this release-note bullet advertises a capability users cannot invoke. Remove the bullet or add the corresponding command surface.

- Reads dataset content back, whether the service hands out a blob URI or the
  container holding it.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:309

• [azd-code-reviewer] An unknown dataset can produce 404 from the version-list call (the API tests explicitly model this), so show <unknown> currently returns the wrapped HTTP response instead of the brief DatasetNotFound error promised by TestCLIUnknownDatasetIsBrief. Translate not-found here before wrapping other listing failures.

				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
				if err != nil {
					return messages.ResolvingLatestDatasetVersion(name, err)

[Copilot]

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated no new comments.

Suppressed comments (8)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:375

• azd-code-reviewer: This contradicts TestCLIDeleteIsIdempotent: deleting a missing version returns an error here. Treat the service's 404 as successful no-op deletion so cleanup scripts remain idempotent.

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}

cli/azd/extensions/azure.ai.dataset/README.md:41

• azd-code-reviewer: The documented endpoint cascade omits the AZURE_AI_PROJECT_ENDPOINT fallbacks and the global extensions.ai-agents.project.context source that projectctx.Resolve checks before host variables. Users can therefore be surprised by an endpoint taking precedence over the three documented sources.

Every command resolves the Foundry project endpoint in this order:

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/README.md:22

• azd-code-reviewer: The documented delete invocation always fails because the implementation requires --version. Include the required flag so the command table contains a runnable example.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:243

• azd-code-reviewer: A 404 still takes this error path, so versions list <unknown> exits nonzero instead of returning the empty result promised by the new tests and command comment. Convert only IsNotFound(err) to an empty DatasetList; preserve other service failures.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:29

• azd-code-reviewer: Any output value other than json is silently treated as human output, so a typo such as -o jsn succeeds and emits a table instead of rejecting an unsupported format. Register per-command azdext.FlagOptions with the supported values/defaults, as required for SDK-managed inherited flags.

	v, err := cmd.Flags().GetString("output")
	if err != nil {
		return ""
	}
	return strings.ToLower(v)

cli/azd/extensions/azure.ai.dataset/README.md:6

• azd-code-reviewer: This onboarding command is guaranteed to fail in the state introduced by this PR: lines 54-57 explicitly say the missing registry entry prevents azd extension install from resolving. Replace it with working local pack/publish instructions until the registry entry lands, or add that entry before publishing this README.

This issue also appears on line 22 of the same file.

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:52

• azd-code-reviewer: Cleanup silently returns when listing or decoding fails, and it also ignores failed delete results. A transient service failure can therefore leave live datasets behind while the suite remains green; report cleanup failures and continue attempting the remaining versions.
  cli/azd/extensions/azure.ai.dataset/CHANGELOG.md:17
• azd-code-reviewer: No command calls DownloadDatasetContent; only unit tests exercise it, and show returns metadata rather than file content. This release note advertises a user-visible capability the extension does not expose. Remove the bullet or add the corresponding command surface.

- Reads dataset content back, whether the service hands out a blob URI or the
  container holding it.

[Copilot]

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated 1 comment.

Suppressed comments (5)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:243

• versions list still returns an error when the service represents an unknown dataset as 404. That contradicts the new empty-success contract and TestCLIVersionsListOfAnUnknownNameSucceeds; the mocked service in version_selection_test.go:76-78 confirms this response shape. Translate only IsNotFound(err) to an empty DatasetList, while preserving other failures.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:29

• Unsupported output values silently fall through to human-readable output: for example, -o yaml exits successfully but emits a table/detail instead of rejecting the typo. That is unsafe for scripts expecting machine-readable output. Register the supported values through azdext.RegisterFlagOptions, as sibling extensions do (for example azure.ai.skills/internal/cmd/skill_list.go:51-53), so invalid formats fail before execution.

	v, err := cmd.Flags().GetString("output")
	if err != nil {
		return ""
	}
	return strings.ToLower(v)

cli/azd/extensions/azure.ai.dataset/README.md:41

• The documented endpoint order omits two sources that the implementation checks: the shared extensions.ai-agents.project.context.endpoint config and the AZURE_AI_PROJECT_ENDPOINT fallback at both environment levels. This can make users troubleshoot or override the wrong source. Document the same four-level precedence used by projectctx.Resolve.

Every command resolves the Foundry project endpoint in this order:

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:584

• Malformed or truncated Blob Storage XML is converted into an empty successful page. The caller then reports that the dataset has no downloadable file, hiding the actual service/transport response problem. Return the XML unmarshal error from parseBlobPage and propagate it through readBlobPage instead of treating parse failure as an empty container.
  cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:47
• Cleanup silently returns when listing or JSON decoding fails and also ignores delete exit codes, so failed live tests can leave datasets in the shared Foundry project without reporting that leak. Record cleanup failures with t.Errorf while continuing through the remaining versions so leaked service state is visible and actionable.

[Copilot]

Pull request overview

Copilot reviewed 64 out of 65 changed files in this pull request and generated no new comments.

Suppressed comments (8)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:309

• azd-code-reviewer: A latest-version lookup that returns 404 currently surfaces the raw listing failure, even though this command promises the brief DatasetNotFound error for an unknown name. Handle not-found here as well as the empty-200 form; otherwise the result depends on which absence response the service returns.

			if version == "" {
				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
				if err != nil {
					return messages.ResolvingLatestDatasetVersion(name, err)
				}

cli/azd/extensions/azure.ai.dataset/README.md:42

• azd-code-reviewer: The documented cascade omits two implemented sources: the persisted extensions.ai-agents.project.context.endpoint value and the AZURE_AI_PROJECT_ENDPOINT fallback at both environment levels. This can make users diagnose the wrong source when a command targets an unexpected project. Document all four levels in their actual precedence order.

Every command resolves the Foundry project endpoint in this order:

1. `--project-endpoint`
2. `FOUNDRY_PROJECT_ENDPOINT` in the active azd environment
3. the host environment variable of the same name

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:374

• azd-code-reviewer: This explicitly turns a 404 into failure, so delete is not actually idempotent when the service reports an absent version with not-found. Ignore that status and continue to the normal success output; the live test's current backend behavior should not be what guarantees idempotence.

			if err := ec.datasetClient.DeleteDatasetVersion(
				ctx, name, version, ProjectEndpointAPIVersion,
			); err != nil {
				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:243

• azd-code-reviewer: The API can represent an unknown dataset with a 404 (the new version-selection test models exactly that), but this branch returns the error before renderDatasets can produce the documented empty successful result. Normalize not-found to an empty list so versions list <unknown> reliably matches its test and CLI contract.

This issue also appears on line 305 of the same file.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:44

• azd-code-reviewer: Dataset is both the service wire model and the value emitted by -o json. Because it has separate camelCase and snake_case URI fields, the CLI's JSON schema changes with the response spelling (dataUri versus data_uri) even though ResolvedBlobURI treats them as one value. Emit a dedicated canonical output DTO for create/update/list/show instead of serializing this compatibility model directly.
  cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:357
• azd-code-reviewer: Every caller uses requireFlag whenever a required flag is absent, without checking whether --no-prompt was supplied. Interactive invocations such as dataset create name therefore falsely claim they were run with --no-prompt. Either make the message unconditional (--<name> is required) or pass the actual no-prompt state and only add this qualifier when true.
  cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:139
• azd-code-reviewer: This adds a host read of AZURE_AI_PROJECT_ENDPOINT, but that variable is absent from the repository's environment-variable reference, and the existing FOUNDRY_PROJECT_ENDPOINT entry says it is only used by azure.ai.agents. Update cli/azd/docs/environment-variables.md, the required single source of truth, for both variables and this extension.
  cli/azd/extensions/azure.ai.dataset/README.md:8
• azd-code-reviewer: This installation command cannot work in the PR's intended state because the registry entry is deliberately excluded; the same README confirms that at lines 54-57. Lead with the supported local-source workflow (or defer the install instruction until registry publication) so the first documented command is runnable.

```console
$ azd extension install azure.ai.dataset
$ azd ai dataset --help

</details>

[Copilot]

Pull request overview

Copilot reviewed 65 out of 66 changed files in this pull request and generated no new comments.

Suppressed comments (4)

cli/azd/extensions/azure.ai.dataset/README.md:22

• [azd-code-reviewer] This documented invocation always fails because delete requires --version. Include the required flag so users can copy a working command.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:375

• [azd-code-reviewer] This 404 branch contradicts the command's documented idempotence: if the service returns not found, delete exits nonzero even though deleting an unregistered version is intended to succeed. Treat a 404 as an already-deleted success and continue to the normal output path.

			if err := ec.datasetClient.DeleteDatasetVersion(
				ctx, name, version, ProjectEndpointAPIVersion,
			); err != nil {
				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}

cli/azd/extensions/azure.ai.dataset/README.md:6

• [azd-code-reviewer] The quick start cannot work in this revision: the TODO below states that azure.ai.dataset has no registry entry, so this install command cannot resolve. Either add the registry entry before presenting this command or replace the quick start with complete local pack/publish/install steps.

This issue also appears on line 22 of the same file.

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:51

• [azd-code-reviewer] Cleanup silently returns when listing or decoding fails and ignores every delete result, so failed live tests can leave persistent datasets in the shared Foundry project while reporting no cleanup failure. Assert the listing, JSON decoding, and each delete so leaked state is visible and actionable.