Repository navigation
fix: Fix to manual scaling setting handling in 005ccbbd-aeab-46ef-80bd-9bd4479412ec - #750
Merged
Merged
Conversation
Takeshi Katano (tksh164)
temporarily deployed
to
Azure
May 30, 2025 17:04 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the AKS node pool query to correctly handle manual vs. auto-scaling scenarios and makes the type filter case-insensitive.
- Changes the resource type match to use case-insensitive operator (
=~). - Splits taint and scaling filters, adding separate logic for
enableAutoScalingtrue/false. - Updates projection to include the
enableAutoScalingflag and conditionally showminCountorcount.
Comments suppressed due to low confidence (1)
azure-resources/ContainerService/managedClusters/kql/005ccbbd-aeab-46ef-80bd-9bd4479412ec.kql:10
- Add or update unit/integration tests to cover both
enableAutoScaling = trueandenableAutoScaling = falsepaths to ensure the query filters correctly in each scenario.
| where (agentPoolProfile.enableAutoScaling == true and agentPoolProfile["minCount"] < 2) or (agentPoolProfile.enableAutoScaling == false and agentPoolProfile["count"] < 2)
Kyle Poineal (kpoineal)
approved these changes
Jun 3, 2025
Takeshi Katano (tksh164)
temporarily deployed
to
Azure
June 3, 2025 15:42 — with
GitHub Actions
Inactive
Takeshi Katano (tksh164)
enabled auto-merge (squash)
June 5, 2025 00:05
Takeshi Katano (tksh164)
had a problem deploying
to
Azure
June 6, 2025 06:28 — with
GitHub Actions
Failure
Takeshi Katano (tksh164)
temporarily deployed
to
Azure
June 11, 2025 09:39 — with
GitHub Actions
Inactive
Takeshi Katano (tksh164)
had a problem deploying
to
Azure
June 26, 2025 04:35 — with
GitHub Actions
Failure
Arthur Clares (arthurclares)
temporarily deployed
to
Azure
September 9, 2025 10:26 — with
GitHub Actions
Inactive
Arthur Clares (arthurclares)
approved these changes
Sep 9, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Fixes to the manual scaling setting handling in 005ccbbd-aeab-46ef-80bd-9bd4479412ec.
Related Issues/Work Items
Breaking Changes
As part of this pull request I have
mainbranchScreenshots