fix(updater): let a beta build switch to the latest channel - #59
Merged
Merged
Conversation
A beta build forced autoupdate:channel back to "beta" on every launch, and the channel was only read at startup. This fork never publishes beta.yml, so a beta build could not reach a release through the updater. Drop the forced revert (allowDowngrade = false already prevents downgrades) and re-read the channel setting before each update check. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getUpdateChannelforcedautoupdate:channelback tobetaon every launch of a beta build, and the channel was read only when theUpdaterwas constructed.beta.yml, so a beta build kept asking for a file that returns 404 and reported nothing new, even with a newer release on the feed.allowDowngrade = falsealready prevents downgrades) and re-readautoupdate:channelbefore every update check, so a settings change applies without a restart.Testing
tsc --noEmit: 0 errorsvitest run: 107 passedautoupdate:channeltolatest, use Check for Updates, and expect it to download the newest release.SSH / wsh
Not applicable: desktop app updater only, no remote-host code.
🤖 Generated with Claude Code
https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6