fix(preview): clear the 16 tsc errors in dev-only preview mocks - #52
Merged
Merged
Conversation
The mock process rows lacked ProcessInfo.numthreads and the default config mock lacked FullConfigType.version/buildtime. Neither file is part of the app build; this only makes `tsc --noEmit` clean. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx tsc --noEmitreported 16 errors onmain; all were type drift in dev-only preview mocks.processviewer.preview.tsx: addnumthreadsto the 15 mockProcessInforows.defaultconfig.ts: addversionandbuildtimeto the mockFullConfigType.Testing
tsc --noEmit: 0 errors (was 16)vitest run: 104 passedprocessviewer.preview.tsx: the file was already not prettier-clean, and reformatting would balloon the diff.SSH / wsh
Not applicable: dev-only preview mocks, no runtime or remote-host code touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6