mavproxy_ftp: support concurrent, faster and resilient transfers - #1733
Closed
tridge wants to merge 6 commits into
Closed
mavproxy_ftp: support concurrent, faster and resilient transfers#1733tridge wants to merge 6 commits into
tridge wants to merge 6 commits into
Conversation
tridge
marked this pull request as ready for review
August 19, 2026 01:27
Contributor
Author
|
closing for #1740 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reworks the MAVProxy FTP client to support multiple simultaneous operations and substantially improve transfer performance and resilience.
This replaces #1724
Why
The previous FTP module effectively serialized operations and used conservative request/response behavior. This prevented commands such as parameter FTP,
ftp list, andftp getfrom progressing together, limited throughput on fast links, and amplified stalls caused by loss or variable latency.The new worker manager isolates transfer state per operation, bounds active sessions, and uses pipelining plus selective retry to keep the link busy without sacrificing compatibility.
Compatibility
Accelerated uploads are enabled only after a server returns the
MFQ1capability marker. Older servers continue to use the legacy single-request upload path. Cumulative acknowledgements remain compatible across old and new client/server combinations.Validation
pytest -q tests/test_mavproxy_ftp.py: 22 passed