🎨 Palette: [UX improvement] Add empty state for results list - #496
🎨 Palette: [UX improvement] Add empty state for results list#496xbmc4lyfe wants to merge 1 commit into
Conversation
Added a centered empty state label to the results list. Kodi custom lists do not automatically handle empty states, leading to a confusing blank screen when there are no items. Before, a blank screen was shown. After, "No results found" is displayed when the list is empty. This provides clear textual feedback to users when no items are available, improving usability and accessibility. Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (7)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe results dialog now shows a centered “No results found” label when results list 50 contains zero items. ChangesResults empty state
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
💡 What
Added a centered "No results found" empty state label to the results list in
results-dialog.xml.🎯 Why
Kodi custom lists (
<control type="list">) do not automatically handle empty states. If a search or filter returned zero results, the dialog would previously display a confusing blank screen without any feedback, leaving the user to wonder if it was still loading or broken.📸 Before/After
Before: Blank screen when
Container(50).NumItemsis 0.After: A centered, muted "No results found" message is displayed clearly.
♿ Accessibility
Provides clear textual feedback to all users when no items are available, significantly improving usability and reducing cognitive load.
PR created automatically by Jules for task 18249113213817315233 started by @xbmc4lyfe