🎨 Palette: [UX improvement] Add empty state message to custom Kodi list - #495
🎨 Palette: [UX improvement] Add empty state message to custom Kodi list#495xbmc4lyfe wants to merge 1 commit into
Conversation
Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe results dialog now shows a centered “No results found” label when results list 50 contains zero items. ChangesResults empty state
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml`:
- Line 269: Replace the hardcoded “No results found” label in the results dialog
with a dedicated localized add-on string reference. Add the corresponding string
entry using a new unique ID, and do not reuse `#30087` because it requires a
format argument.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 463fb950-1c34-458d-8346-c791c7c52195
📒 Files selected for processing (1)
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
📜 Review details
⏰ Context from checks skipped due to timeout. (7)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Analyze (python)
- GitHub Check: lint
- GitHub Check: test
- GitHub Check: Scan
- GitHub Check: coverage
- GitHub Check: Analyze (python)
| <!-- Empty state message --> | ||
| <control type="label"> | ||
| <left>0</left><top>60</top><width>1920</width><height>975</height> | ||
| <label>No results found</label> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
fd -t f 'strings\.po|strings\.xml' repo/plugin.video.nzbdav
rg -n 'LOCALIZE|ADDON\[|No results found' repo/plugin.video.nzbdavRepository: Appz4Fun/nzbdavkodi
Length of output: 671
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- localization entries ---'
sed -n '330,375p' repo/plugin.video.nzbdav/resources/language/resource.language.en_gb/strings.po
printf '%s\n' '--- localization usage in skin XML ---'
rg -n -C 2 '\$LOCALIZE|\$ADDON\[|<label>[^<]*[A-Za-z][^<$]*</label>' repo/plugin.video.nzbdav/resources/skins repo/plugin.video.nzbdav
printf '%s\n' '--- related dialog and i18n code ---'
sed -n '235,285p' repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
sed -n '1,45p' repo/plugin.video.nzbdav/resources/lib/i18n.py
printf '%s\n' '--- numeric localization IDs ---'
awk '/^msgctxt / || /^msgid / || /^msgstr / {print NR ":" $0}' repo/plugin.video.nzbdav/resources/language/resource.language.en_gb/strings.po | tail -80Repository: Appz4Fun/nzbdavkodi
Length of output: 50375
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- add-on ID ---'
rg -n '<addon ' repo/plugin.video.nzbdav/addon.xml
printf '%s\n' '--- localized-label syntax in repository ---'
rg -n --glob '*.xml' '\$LOCALIZE\[|\$ADDON\[' . || true
printf '%s\n' '--- exact empty-state localization entries and usages ---'
rg -n -C 1 'No results found($| for \{\})|30087|30089' \
repo/plugin.video.nzbdav/resources/language \
repo/plugin.video.nzbdav/resources/lib \
repo/plugin.video.nzbdav/resources/skins
printf '%s\n' '--- i18n helper implementation ---'
rg -n -A 12 -B 4 'def (get_localized|localize)|getLocalizedString|get_localized' \
repo/plugin.video.nzbdav/resources/lib/i18n.pyRepository: Appz4Fun/nzbdavkodi
Length of output: 3642
Localize the empty-state label.
Add a dedicated entry for No results found and reference it with the plugin.video.nzbdav add-on string ID. Do not reuse #30087; that entry requires a {} argument.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml` at
line 269, Replace the hardcoded “No results found” label in the results dialog
with a dedicated localized add-on string reference. Add the corresponding string
entry using a new unique ID, and do not reuse `#30087` because it requires a
format argument.
Source: MCP tools
1 participant
💡 What: Added an empty state label ("No results found") to the results list in
results-dialog.xmlusing a visibility condition tied to the list's item count.🎯 Why: To handle empty states in custom Kodi lists which otherwise result in a confusing blank screen.
📸 Before/After: Before, a blank screen; After, a "No results found" message centered on screen.
♿ Accessibility: Improves user understanding by providing clear visual feedback when no items are present.
PR created automatically by Jules for task 15729391071377223608 started by @xbmc4lyfe