Skip to content

🎨 Palette: Add empty state feedback to results list - #494

Draft
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette-ux-empty-state-860346523930574305
Draft

🎨 Palette: Add empty state feedback to results list#494
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette-ux-empty-state-860346523930574305

Conversation

@xbmc4lyfe

Copy link
Copy Markdown
Collaborator

What:
Added an explicit "No results found" label that appears centered over the main results list area when the list container is empty.

Why:
Kodi's custom list controls do not inherently provide an empty state fallback. Previously, when a search yielded zero results, the UI would simply show a blank screen with no indication if it was still loading or if the query had failed, which creates confusion.

Before/After:
Before: Empty list just shows background texture.
After: A centered, dim text label reads "No results found" when Container(50).NumItems is exactly 0.

Accessibility:
This provides necessary, immediate feedback to the user regarding system state, satisfying basic usability heuristic criteria for state visibility without relying on side-channel notifications.


PR created automatically by Jules for task 860346523930574305 started by @xbmc4lyfe

Added a centralized label with a visibility condition (`Integer.IsEqual(Container(50).NumItems,0)`) to ensure users receive clear, immediate feedback ("No results found") instead of a confusing blank screen when the custom list returns empty.

Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the addon label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

βœ… No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f1aa828-906a-46f5-821f-e550fc1adb8d

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between c8dfe60 and 486b5f4.

πŸ“’ Files selected for processing (1)
  • repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
πŸ“œ Recent review details
⏰ Context from checks skipped due to timeout. (7)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: lint
  • GitHub Check: test
  • GitHub Check: coverage
  • GitHub Check: Scan
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (python)
πŸ”‡ Additional comments (1)
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml (1)

266-275: LGTM!


πŸ“ Walkthrough

Summary by CodeRabbit

  • New Features
    • Added a centered β€œNo results found” message when the results list is empty.

Walkthrough

The results dialog now shows a centered β€œNo results found” label when list control 50 contains zero items.

Changes

Empty Results State

Layer / File(s) Summary
Display empty-state label
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
Adds a centered label over the results area. The label appears only when Container(50).NumItems equals zero.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ponchopig

Poem

A bunny sees the empty screen,
No result hops into view.
A friendly label now appears,
Centered, clear, and true.
β€œNo results found,” the bunny grins.

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description check βœ… Passed The description directly explains the added empty-state label, its visibility condition, and the user-facing purpose.
Title check βœ… Passed The title clearly identifies the addition of empty-state feedback to the results list.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-ux-empty-state-860346523930574305
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch palette-ux-empty-state-860346523930574305

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from PonchoPig August 10, 2026 00:37
@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage in commit 486b5f4 in the palette-ux-empty-sta... branch remains at 88%, unchanged from commit c8dfe60 in the main branch.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant