π¨ Palette: Add empty state feedback to results list - #494
Conversation
Added a centralized label with a visibility condition (`Integer.IsEqual(Container(50).NumItems,0)`) to ensure users receive clear, immediate feedback ("No results found") instead of a confusing blank screen when the custom list returns empty.
Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Reviewβ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (1)
π Recent review detailsβ° Context from checks skipped due to timeout. (7)
π Additional comments (1)
π WalkthroughSummary by CodeRabbit
WalkthroughThe results dialog now shows a centered βNo results foundβ label when list control 50 contains zero items. ChangesEmpty Results State
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
β¨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards βπ’ Issues
|
What:
Added an explicit "No results found" label that appears centered over the main results list area when the list container is empty.
Why:
Kodi's custom list controls do not inherently provide an empty state fallback. Previously, when a search yielded zero results, the UI would simply show a blank screen with no indication if it was still loading or if the query had failed, which creates confusion.
Before/After:
Before: Empty list just shows background texture.
After: A centered, dim text label reads "No results found" when
Container(50).NumItemsis exactly0.Accessibility:
This provides necessary, immediate feedback to the user regarding system state, satisfying basic usability heuristic criteria for state visibility without relying on side-channel notifications.
PR created automatically by Jules for task 860346523930574305 started by @xbmc4lyfe