Skip to content

🎨 Palette: Add empty state handler to results dialog list - #493

Draft
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette/ux-empty-state-list-1266913365990646976
Draft

🎨 Palette: Add empty state handler to results dialog list#493
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette/ux-empty-state-list-1266913365990646976

Conversation

@xbmc4lyfe

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: Added a clear "No results found." empty state label to the Results dialog.
🎯 Why: In Kodi, custom UI lists don't natively handle empty states, which leaves users staring at a completely blank screen, confused if it's still loading or if they just got zero results.
πŸ“Έ Before/After: Before: Blank screen. After: A centered "No results found." message.
β™Ώ Accessibility: The empty state label makes the interface significantly more clear and eliminates cognitive load and uncertainty.


PR created automatically by Jules for task 1266913365990646976 started by @xbmc4lyfe

Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the addon label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

βœ… No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 70840640-3188-4b22-aa64-55b6693a4303

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between c8dfe60 and aec8c32.

πŸ“’ Files selected for processing (1)
  • repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
πŸ“œ Recent review details
⏰ Context from checks skipped due to timeout. (7)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: test
  • GitHub Check: lint
  • GitHub Check: coverage
  • GitHub Check: Analyze (python)
  • GitHub Check: Scan
  • GitHub Check: Analyze (python)
πŸ”‡ Additional comments (1)
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml (1)

266-275: LGTM!


πŸ“ Walkthrough

Summary by CodeRabbit

  • New Features
    • Added an empty-state message to the results dialog when no results are available.

Walkthrough

The results dialog now shows a centered β€œNo results found.” label when results list 50 contains no items.

Changes

Results dialog

Layer / File(s) Summary
Empty-state label
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
Adds a centered label over the results area. The label appears only when results list 50 has zero items.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ponchopig

Poem

A rabbit checks the empty screen,
No results hide where none have been.
A centered note now greets the view,
β€œNo results found.” appears in blue.
The dialog stays clear and bright.

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly summarizes the addition of an empty-state handler to the results dialog list.
Description check βœ… Passed The description directly explains the added empty-state label, its purpose, and its user interface benefits.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/ux-empty-state-list-1266913365990646976
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch palette/ux-empty-state-list-1266913365990646976

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from PonchoPig August 9, 2026 00:16
@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage in commit aec8c32 in the palette/ux-empty-sta... branch remains at 88%, unchanged from commit c8dfe60 in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant