π¨ Palette: Add empty state handler to results dialog list - #493
π¨ Palette: Add empty state handler to results dialog list#493xbmc4lyfe wants to merge 1 commit into
Conversation
Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Reviewβ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (1)
π Recent review detailsβ° Context from checks skipped due to timeout. (7)
π Additional comments (1)
π WalkthroughSummary by CodeRabbit
WalkthroughThe results dialog now shows a centered βNo results found.β label when results list ChangesResults dialog
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
β¨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards βπ’ Issues
|
π‘ What: Added a clear "No results found." empty state label to the Results dialog.
π― Why: In Kodi, custom UI lists don't natively handle empty states, which leaves users staring at a completely blank screen, confused if it's still loading or if they just got zero results.
πΈ Before/After: Before: Blank screen. After: A centered "No results found." message.
βΏ Accessibility: The empty state label makes the interface significantly more clear and eliminates cognitive load and uncertainty.
PR created automatically by Jules for task 1266913365990646976 started by @xbmc4lyfe