Skip to content

⚡ Bolt: Optimize re.sub callback in PTT parse #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xbmc4lyfe wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Optimize re.sub callback in PTT parse #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions repo/plugin.video.nzbdav/resources/lib/ptt/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,22 +47,16 @@ def _apply_russian_cast_regex(s: str) -> str:
# NOT_ONLY_NON_ENGLISH_REGEX: the first alternative used a variable-width lookbehind.
# Replaced with a helper function _apply_not_only_non_english_regex below.
_NOT_ONLY_NON_ENG_PART1 = re.compile(
rf"[a-zA-Z][^{NON_ENGLISH_CHARS}]+[{NON_ENGLISH_CHARS}].*[{NON_ENGLISH_CHARS}]"
rf"([a-zA-Z][^{NON_ENGLISH_CHARS}]+)[{NON_ENGLISH_CHARS}].*[{NON_ENGLISH_CHARS}]"
)
_NOT_ONLY_NON_ENG_PART2 = re.compile(
rf"[{NON_ENGLISH_CHARS}].*[{NON_ENGLISH_CHARS}](?=[^{NON_ENGLISH_CHARS}]+[a-zA-Z])"
)
_ENGLISH_PREFIX = re.compile(rf"[a-zA-Z][^{NON_ENGLISH_CHARS}]+")


def _apply_not_only_non_english_regex(s: str) -> str:
"""Remove non-English sections that appear inline within English text."""

def _keep_english_prefix(m: re.Match) -> str:
prefix = _ENGLISH_PREFIX.match(m.group(0))
return prefix.group(0) if prefix else ""

s = _NOT_ONLY_NON_ENG_PART1.sub(_keep_english_prefix, s)
s = _NOT_ONLY_NON_ENG_PART1.sub(r"\1", s)
s = _NOT_ONLY_NON_ENG_PART2.sub("", s)
return s

Expand Down