Skip to content

🎨 Palette: Add empty state label to results dialog - #488

Draft
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette-add-empty-state-label-6454817797587338264
Draft

🎨 Palette: Add empty state label to results dialog#488
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette-add-empty-state-label-6454817797587338264

Conversation

@xbmc4lyfe

Copy link
Copy Markdown
Collaborator
  • πŸ’‘ What: Added an empty state label indicating "No results found." to the results dialog.
  • 🎯 Why: Custom lists in Kodi skins do not display anything when empty, resulting in a confusing blank screen.
  • πŸ“Έ Before/After: Before, empty lists were blank. After, an explicit message clarifies the lack of results.
  • β™Ώ Accessibility: Improves user confidence and prevents confusion when navigating to empty result sets.

PR created automatically by Jules for task 6454817797587338264 started by @xbmc4lyfe

Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the addon label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

βœ… No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 05b7d372-2910-4eee-a0a6-53dd8e216fa0

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between c8dfe60 and 1e4189a.

πŸ“’ Files selected for processing (1)
  • repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
πŸ“œ Recent review details
⏰ Context from checks skipped due to timeout. (7)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: coverage
  • GitHub Check: lint
  • GitHub Check: Scan
  • GitHub Check: test
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (python)

πŸ“ Walkthrough

Summary by CodeRabbit

  • New Features
    • Added a centered β€œNo results found” message when a results list is empty.

Walkthrough

The results dialog now shows a centered β€œNo results found.” label when results list 50 contains zero items.

Changes

Results empty state

Layer / File(s) Summary
Add empty-state label
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
Displays the centered label only when Container(50).NumItems equals zero.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ponchopig

Poem

A rabbit checks the empty screen,
No result hops into view.
A gentle label now appears,
β€œNo results found.” says true.
Then off I bounceβ€”boing!

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly identifies the Palette results dialog change and the added empty-state label.
Description check βœ… Passed The description accurately explains the empty-state label, its purpose, and its user-facing effect.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-add-empty-state-label-6454817797587338264
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch palette-add-empty-state-label-6454817797587338264

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from PonchoPig August 5, 2026 00:23
@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage in commit 1e4189a in the palette-add-empty-st... branch remains at 88%, unchanged from commit c8dfe60 in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant