Skip to content

🎨 Palette: Add empty state message to results dialog #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xbmc4lyfe wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🎨 Palette: Add empty state message to results dialog #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,5 +310,16 @@
<aligny>center</aligny>
</control>

<!-- Empty state message -->
<control type="label">
<left>0</left><top>60</top><width>1910</width><height>975</height>
<label>No results found</label>

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

fd -i -t f 'strings\.po$' .
rg -n 'No results found|LOCALIZE' --glob '*.xml' --glob '*.po' .

Repository: Appz4Fun/nzbdavkodi

Length of output: 591

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== resource files =="
fd -i -t f 'strings\.po$|resource\.strings\.zip$|addon\.xml' repo/plugin.video.nzbdav/resources

echo "== strings.po relevant entries =="
sed -n '340,370p' repo/plugin.video.nzbdav/resources/language/resource.language.en_gb/strings.po

echo "== add-on strings definitions =="
find repo/plugin.video.nzbdav -type f \( -name "addon.xml" -o -path "*/resources/strings/*" -o -name "*.xml" \) | sed -n '1,120p'

echo "== all strings.po files and localizations =="
find repo/plugin.video.nzbdav -path '*/language/*strings.po' | sort | while read -r f; do echo "-- $f"; rg -n 'messageid|msgid "No result|LOCALIZE' "$f" || true; done

Repository: Appz4Fun/nzbdavkodi

Length of output: 1335

🌐 Web query:

Kodi skin strings.po messageid comment string IDs start numbering resource.language strings.po 30001

💡 Result:

In Kodi development, string IDs in strings.po files are used to localize user interface text, and specific numeric ranges are reserved for different types of add-ons [1][2]. These IDs are encoded in the msgctxt field of the GNU Gettext-formatted strings.po file using the syntax msgctxt "#ID" [1][3]. The reserved numeric ranges for string IDs are as follows: * 30000 thru 30999: Reserved for plugins and plugin settings [1][2] * 31000 thru 31999: Reserved for skins [1][2] * 32000 thru 32999: Reserved for scripts [1][2] * 33000 thru 33999: Reserved for common strings used in add-ons [1][2] For a skin, you should use an ID within the 31000–31999 range [1][4]. While some users have historically experimented with IDs outside these ranges, the system is designed to enforce these boundaries, and using an ID outside the designated range for your add-on type may result in the label failing to display correctly in the GUI [5]. If you are working within a skin, ensure your entry follows the required format: msgctxt "#31001" msgid "Your string text" msgstr "" If you need to access a string from an add-on within a skin, it is recommended to use the $ADDON[addon.id stringID] format rather than the standard $LOCALIZE[ID] function, as this explicitly targets the correct add-on's string resource [5]. For plugin-specific settings, IDs like 30001 are standard practice within the allocated 30000–30999 range [1][6].

Citations:

Use a skin-localized empty-state string.

No results found is hardcoded in a skin XML, while Kodi skin strings use the #31000–#31999 range with $LOCALIZE[...]. Existing No results found for {} entries use plugin string IDs, so this empty list text should not reuse those IDs.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml` at
line 316, Replace the hardcoded “No results found” label in the results dialog
with a skin-localized string using a new ID in the `#31000`–#31999 range and the
$LOCALIZE[...] syntax. Add the corresponding skin string definition, using a
distinct ID rather than reusing existing plugin “No results found for {}”
strings.

<font>font13</font>
<textcolor>FF9CA3AF</textcolor>
<align>center</align>
<aligny>center</aligny>
<visible>Integer.IsEqual(Container(50).NumItems,0)</visible>
</control>

</controls>
</window>