fix(Build): examples were not building correctly - #291
Merged
Merged
Conversation
fubuloubu
force-pushed
the
fix/build/examples
branch
from
January 19, 2026 19:16
d3e76c3 to
e92c01a
Compare
fubuloubu
force-pushed
the
fix/build/examples
branch
from
January 19, 2026 21:46
6e57a78 to
6d18af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Noticed in CI that the example bots were not building
This PR also adds a flag to
silverback buildto select which SDK version to use as the base image.Additionally, it makes some other minor refactors to reduce unnecessarily complex code, and adds a test for checking that the
latestSDK (in PR, the build image from the previous job) can build images for itself.How I did it
How to verify it
Checklist