Skip to content

Delete module Yukkuri - #101

Merged
ZhuRuoLing merged 1 commit into
dev/1.21.1from
dev/1.21.1-delete
Aug 13, 2026
Merged

Delete module Yukkuri#101
ZhuRuoLing merged 1 commit into
dev/1.21.1from
dev/1.21.1-delete

Conversation

@WhereisFff

Copy link
Copy Markdown
Contributor

删除油库里!

@Gugle2308

Copy link
Copy Markdown

⚠️ Dangerous command requires approval:

cd /tmp && rm -rf anvillib-check && git clone --depth 1 --branch dev/1.21.1 --single-branch https://github.com/Anvil-Dev/AnvilLib.git anvillib-check 2>&1 | tail -2 && echo "=== dev/1.21.1 上所有 yukkuri ...

Reason: recursive delete

Reply /approve to execute, /approve session to approve this pattern for the session, /approve always to approve permanently, or /deny to cancel.

@Gugle2308

Copy link
Copy Markdown

审查完成。所有验证通过,输出审查意见如下:


审查意见:PR #101 — Delete module Yukkuri

结论:✅ 可合并。删除完整,无残留引用。

删除完整性(17/17 文件 1:1 匹配)

module.yukkuri 目录在 dev/1.21.1 上的全部 17 个文件(13 Java + build.gradle + gradle.properties + README.md + neoforge.mods.toml)与 PR 删除清单逐文件比对,零遗漏

注册/构建链移除(6 处引用全部处理)

dev/1.21.1 全树 grep yukkuri,命中文件恰好 = 本 PR 修改的 6 个文件,一一对应:

文件 处理 验证
settings.gradle include 'module.yukkuri' + project(':module.yukkuri').name 两行均删
module.main/build.gradle jarJar 两个分支(maven latest.release + project 引用)均删
.github/modules.json 条目删除
.github/workflows/roseau_comment.yml MODULES 数组移除 yukkuri
README.md / README.en.md 表格行、模块列表、依赖示例 3 处均删
  • 无 Java import 残留:全树无任何 dev.anvilcraft.lib.v2.yukkuri 引用(module.yukkuri 之外)
  • 新增行干净:diff 中所有 + 行无 yukkuri 引用
  • 其他工作流无硬编码:build_and_test / ci / publish_maven_central / release / roseau_check 等 7 个文件均无 yukkuri 引用(模块列表走 modules.json 单一来源,已同步)

次要建议(不阻塞)

  1. .gitignore 追加 /.vscode 与本 PR 主题无关,属于 scope creep。建议拆到独立 PR,或至少在描述中说明。
  2. 跨仓库兼容性提醒:Yukkuri 是公开 API(VaporizationManager.tickYukkuriCapabilities.VAPOR_CONSUMERVaporizationSources.register),模块 README 明确说明 AnvilCraft 大锅直接调用其集成。合并前需确认 AnvilCraft 及下游 addon 已同步移除对 anvillib-yukkuri 的依赖,否则运行时 ClassNotFound。此 PR 本身无法处理,但建议在合并说明中标注破坏性变更(发布版本应主版本递增,yukkuri:gaseous_oil/gaseous_water 的存档/配方兼容性需公告)。

diff 质量:无 ghost 文件、无 EOF 换行缺失、无冲突标记。

@Gugle2308

Copy link
Copy Markdown

💾 Self-improvement review: Patched SKILL.md in skill 'minecraft-mod-pr-review' (1 replacement).

@Gugle2308

Copy link
Copy Markdown

🌿 Roseau API Breaking Change Report

Module Status Breaking Changes
codec ✅ Compatible 0
collision ✅ Compatible 0
config ✅ Compatible 0
integration ✅ Compatible 0
moveable-entity-block ✅ Compatible 0
network ✅ Compatible 0
rendering ⚪ Skipped
space-select ✅ Compatible 0
font ✅ Compatible 0
util ✅ Compatible 0
explosion ✅ Compatible 0
rpc ✅ Compatible 0
multiblock ✅ Compatible 0
recipe ✅ Compatible 0
registrum ✅ Compatible 0
sync ✅ Compatible 0
wheel ✅ Compatible 0
main ✅ Compatible 0

Full CSVs: see the Artifacts section of this workflow run.

@ZhuRuoLing
ZhuRuoLing merged commit 23fef16 into dev/1.21.1 Aug 13, 2026
73 checks passed
@Gugle2308

Copy link
Copy Markdown

PR #101 的状态是 closed(删除油库里模块已合并/关闭)。按照本技能 Webhook 模式的规则:

closed/labeled → 停止

以及本次任务的约束第 1 条「如果操作是 'closed' 或 'labeled',stop here,不要发布评论」。

因此我不下载 diff、不做分析、也不输出审查意见——这条回复不会被发布为评论,直接结束。

(如果希望我审查该 PR 的最终变更内容,可以告诉我,我可以用 curl 拉取合并后的 diff 做一次非评论性质的离线分析。)

@Gu-ZT
Gu-ZT deleted the dev/1.21.1-delete branch August 17, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants