Skip to content

Fix direct and incremental assembly builds - #1

Merged
Aneesh495 merged 1 commit into
mainfrom
fix/incremental-assembly-builds
Nov 12, 2026
Merged

Aneesh495 merged 1 commit into
mainfrom
fix/incremental-assembly-builds

Conversation

@Aneesh495

Copy link
Copy Markdown
Owner

Building bin/planck directly from a clean checkout failed because its output directory was only created by the unrelated dirs target. Changes to shared .inc files also left existing object files unchanged.

Give the executable an order-only dependency on its output directory and make both source and test objects depend on the shared assembly includes. This makes direct-target builds work and prevents stale objects after ABI or constant changes.

Validation: reproduced the clean direct-target failure before the change; built and linked the ELF executable after it; confirmed an up-to-date build needs no work and changing rv32.inc schedules all 41 objects for reassembly; git diff --check passes. The repository CI runs the Linux runtime tests.

@Aneesh495
Aneesh495 merged commit 4d569ef into main Nov 12, 2026
2 checks passed
@Aneesh495
Aneesh495 deleted the fix/incremental-assembly-builds branch November 12, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant