Repository navigation
Fix direct and incremental assembly builds - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building
bin/planckdirectly from a clean checkout failed because its output directory was only created by the unrelateddirstarget. Changes to shared.incfiles also left existing object files unchanged.Give the executable an order-only dependency on its output directory and make both source and test objects depend on the shared assembly includes. This makes direct-target builds work and prevents stale objects after ABI or constant changes.
Validation: reproduced the clean direct-target failure before the change; built and linked the ELF executable after it; confirmed an up-to-date build needs no work and changing
rv32.incschedules all 41 objects for reassembly;git diff --checkpasses. The repository CI runs the Linux runtime tests.