feat(storage): migrate media to S3-compatible storage - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/uploads/serving during the transition and add a resumable migration command that uploads each legacy object before atomically updating its database URL.Link to issue or ticket
N/A
Steps to QA
Start the local services with
npm run services:initand confirm the MinIO API is available on port9000.Start the application and upload a profile picture; confirm both cropped and original objects appear under
profile-pictures/in the configured bucket.Upload, replace, and remove a project logo and project media; confirm the database URLs use the configured public object-storage URL and replaced/removed objects are deleted.
Run
npm run db:migrate-media --workspace=@repo/dband confirm it reports legacy media without changing files or database rows.Run the migration with
-- --applyagainst a prepared environment and confirm uploaded objects are available before their database URLs change; rerun the dry run and confirm zero candidates remain.Verify the production CloudFront URLs for the migrated profile images return
200and render in both the profile page and profile-picture editor.Run the automated checks:
npm test --workspace=api -- --runInBandnpm run buildnpx turbo run lintnpx turbo run check-typesnpm run format:checkScreenshots
N/A