refactor(storage): remove legacy upload filesystem - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/uploadsstatic-file route from the API now that production media has been migrated to object storage.Link to issue or ticket
N/A
Steps to QA
Confirm the production media migration dry run reports zero legacy records.
Build the application with
npm run buildand confirm both the API and web production builds succeed.Start the API with the object-storage environment variables configured and confirm it starts without creating an
apps/api/uploadsdirectory.Upload a profile picture and project media, then confirm the files are written to object storage and their public URLs use the configured CloudFront domain.
Run the automated checks:
npm test --workspace=api -- --runInBandnpx turbo run lintnpx turbo run check-typesnpm run format:checkScreenshots
N/A