Ci: drop the workflow-wide 8 GB NODE_OPTIONS heap ceiling from validation - #859
Open
AmaadMartin wants to merge 1 commit into
Open
Ci: drop the workflow-wide 8 GB NODE_OPTIONS heap ceiling from validation#859AmaadMartin wants to merge 1 commit into
AmaadMartin wants to merge 1 commit into
Conversation
macos-latest is a 3 CPU / 7 GB runner, so --max-old-space-size=8192 cannot be honoured there. Node sizes its own default ceiling from the host memory, which is correct on every runner in the matrix. The vitest workers keep their ceiling: vitest.config.ts sets it through poolOptions.forks.execArgv, which wins over an inherited NODE_OPTIONS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
N/A
Problem:
validation.yamlsets a workflow-wideNODE_OPTIONS=--max-old-space-size=8192.macos-latestis a 3 CPU / 7 GB runner, so an 8 GB per-process heap ceiling cannot be honoured there. The override also reaches every forked vitest worker.Solution: I deleted the
env:block, so each runner gets the ceiling Node derives from its own physical memory. On Node v22.22.2 that default measures 4144 MB, against 8240 MB under the override.cross-language-integration.ymlalready runsnpm install,npm run buildand the cross-language tests onmacos-latestwith no override.Worker ceilings do not change.
vitest.config.tssets them throughpoolOptions.forks.execArgv, which wins over an inheritedNODE_OPTIONS(measured: parent 8240 MB, child withexecArgv=--max-old-space-size=2048gets 2096 MB). Right-sizing that value is a separate change (#770).Collision check: I read the diff of every open fork PR that touches
.github/workflows/validation.yaml(#799, #756, #713, #669, #652, #651, #649, #631, #593, #574, #572, #571, #566, #648). None of them adds or removesNODE_OPTIONS, so this does not duplicate or conflict with any of them.Testing Plan
Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.
Unit Tests:
[ ] I have added or updated unit tests for my change. The change deletes three lines of CI config and adds no code to cover, and the repository has no harness that asserts on workflow YAML.
[ ] All unit tests pass locally. The suite runs in this PR's own
validationjob, on every OS in the matrix, under the default heap ceiling. That run is the test.Manual End-to-End (E2E) Tests:
Before pushing:
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/validation.yaml'))"— parses.git diff --stat—1 file changed, 3 deletions(-).grep -rn "NODE_OPTIONS\|max-old-space" .github/— no output.One gap: if #756 lands first, this PR's matrix is ubuntu + windows only, and macOS is covered by the post-merge push run.
Checklist
[x] I have read the CONTRIBUTING.md document.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas. A comment explaining a variable that is no longer set would be noise.
[ ] I have added tests that prove my fix is effective or that my feature works. See the note above.
[ ] New and existing unit tests pass locally with my changes. The change touches no code, so the suite is exercised by this PR's
validationrun rather than locally.