Fix: make cli_create_test hermetic against ambient GOOGLE_CLOUD_* env vars (duplicate of #569)

dev/test/cli/cli_create_test.ts

@@ -70,11 +70,16 @@ describe('createAgent', () => {
 
   beforeEach(() => {
     vi.clearAllMocks();
+    // createAgent() reads these before shelling out to gcloud, so a
+    // developer's exported values would shadow the execSync mock below.
+    vi.stubEnv('GOOGLE_CLOUD_PROJECT', undefined);
+    vi.stubEnv('GOOGLE_CLOUD_LOCATION', undefined);
     (isCancel as unknown as Mock).mockReturnValue(false);
     (listFiles as Mock).mockResolvedValue(['file1', 'file2']);
   });
 
   afterEach(() => {
+    vi.unstubAllEnvs();
     vi.restoreAllMocks();
   });
 
@@ -222,6 +227,64 @@ describe('createAgent', () => {
       );
     });
 
+    it('should prefer ambient Google Cloud env vars over gcloud config', async () => {
+      vi.stubEnv('GOOGLE_CLOUD_PROJECT', 'env-project');
+      vi.stubEnv('GOOGLE_CLOUD_LOCATION', 'env-region');
+
+      (select as Mock).mockResolvedValueOnce('gemini-2.5-flash');
+      (select as Mock).mockResolvedValueOnce('ts');
+      (select as Mock).mockResolvedValueOnce('vertex'); // Backend
+
+      (execSync as Mock).mockReturnValue('gcloud-project\n');
+
+      (text as Mock).mockResolvedValueOnce('env-project');
+      (text as Mock).mockResolvedValueOnce('env-region');
+
+      await createAgent(getFreshOptions());
+
+      expect(execSync).not.toHaveBeenCalled();
+      expect(text).toHaveBeenCalledWith(
+        expect.objectContaining({
+          message: 'Enter the Google Cloud Project ID',
+          initialValue: 'env-project',
+        }),
+      );
+      expect(text).toHaveBeenCalledWith(
+        expect.objectContaining({
+          message: 'Enter the Google Cloud Region',
+          initialValue: 'env-region',
+        }),
+      );
+    });
+
+    it('should seed empty defaults when the gcloud lookup fails', async () => {
+      (select as Mock).mockResolvedValueOnce('gemini-2.5-flash');
+      (select as Mock).mockResolvedValueOnce('ts');
+      (select as Mock).mockResolvedValueOnce('vertex'); // Backend
+
+      (execSync as Mock).mockImplementation(() => {
+        throw new Error('gcloud: command not found');
+      });
+
+      (text as Mock).mockResolvedValueOnce('manual-project');
+      (text as Mock).mockResolvedValueOnce('manual-region');
+
+      await createAgent(getFreshOptions());
+
+      expect(text).toHaveBeenCalledWith(
+        expect.objectContaining({
+          message: 'Enter the Google Cloud Project ID',
+          initialValue: '',
+        }),
+      );
+      expect(text).toHaveBeenCalledWith(
+        expect.objectContaining({
+          message: 'Enter the Google Cloud Region',
+          initialValue: '',
+        }),
+      );
+    });
+
     it('should exit without writing files if project prompt is cancelled', async () => {
       // Mirror clack's contract: only the raw cancel symbol counts as a cancel.
       (isCancel as unknown as Mock).mockImplementation(