Skip to content

Test: fail webui_test fast when the repo has not been built (stacked on #359) #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmaadMartin wants to merge 1 commit into
base: fix/webui-test-named-hook-timeouts
Choose a base branch
from
+24 −0
Open

Test: fail webui_test fast when the repo has not been built (stacked on #359) #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/integration/adk_web/webui_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

import {AdkApiServer} from '@google/adk-devtools';
import * as fs from 'node:fs';
import * as http from 'node:http';
import * as path from 'node:path';
import {fileURLToPath} from 'node:url';
Expand All @@ -28,7 +29,30 @@ const SERVER_START_TIMEOUT = 20000;
*/
const SERVER_STOP_TIMEOUT = 10000;

/**
* Built artifacts this suite serves over HTTP: the CLI entrypoint spawned by
* `AdkTsApiServer`, and the adk-web bundle `AdkApiServer` mounts at `/dev-ui`.
* `dist/browser` is a downloaded release asset rather than a compile output,
* so it can be missing from an otherwise-built tree.
*/
const REQUIRED_BUILD_ARTIFACTS = [
path.resolve(__dirname, '../../../dev/dist/esm/cli_entrypoint.js'),
path.resolve(__dirname, '../../../dev/dist/browser/index.html'),
];

function assertRepoIsBuilt(): void {
const missing = REQUIRED_BUILD_ARTIFACTS.filter((p) => !fs.existsSync(p));
if (missing.length > 0) {
throw new Error(
'webui_test.ts exercises built output; run `npm run build` first. ' +
`Missing: ${missing.join(', ')}`,
);
}
}

describe('WebUI Integration Test', () => {
beforeAll(assertRepoIsBuilt);

describe.each([
{
name: 'Run from ADK CLI',
Expand Down
Loading