Chore: remove stray output.txt from the repository root - #473
Open
AmaadMartin wants to merge 1 commit into
Open
Conversation
Committed accidentally in google#276 alongside the skills script execution change. Nothing in the repository reads, writes, or resolves this path, and no supported workflow regenerates it at the repository root.
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
No existing issue. Related (the change that introduced the file): feat: skills: support script execution google/adk-js#276
Problem: A 5-byte file named
output.txt, containinghellowith no trailing newline, is tracked at the repository root. It was committed by accident in feat: skills: support script execution google/adk-js#276 ("feat: skills: support script execution"), where it appears in the diffstat asoutput.txt | 1 +amid ~34 legitimate source, test and fixture changes — an execution artifact the author's local test run materialized into the working directory. Nothing in the repository reads, writes, or resolves that path.git grep -n 'output\.txt'returns exactly four hits, none of which touch the repository root:core/test/code_executors/unsafe_local_code_executor_test.ts:301,318— a script string writingnew_output.txtinside the executor's ownmkdtempsandbox, plus the assertion on that name.core/test/tools/skills/run_skill_script_tool_test.ts:210andcore/test/tools/skills/run_skill_inline_script_tool_test.ts:226— in-memoryFileobject literals passed to a mockedmaterializeFiles.No
.gitignore,.prettierignore,eslint.config.js,tsconfig.json,typedoc.json,vitest.config.ts, workflow, script orpackage.jsonmanifest mentions it (scripts/check_license.shonly scans*.js/*.ts, so it is invisible to the license check). The file is inert history that pollutesgit statusfor any contributor whose tooling happens to write to./output.txt.Solution: Delete it with
git rm output.txt, so the removal is staged deterministically. The entire diff isoutput.txt | 1 -, one deletion, nothing else. There is no runtime, API or behavioral change, and published npm tarballs are unaffected — the root workspace package is not published and each workspace packs only from its own directory.Deliberately NOT adding an
output.txtentry to.gitignore, for three reasons:output.txtline is a repo-wide pattern — git matches an unanchored, slash-free pattern at every directory depth. It would silently hide a legitimate futureoutput.txtanywhere in the tree, including undertests/integration/**, where the skills tests already useoutput.txtas their canonical example output-file name. That is a real footgun, not a hypothetical one..gitignoreentries are all tool-generated directories (dist/,node_modules/,coverage/,dev/.cache/), editor droppings, or secrets (.env). A generic single-file name of an artifact that no supported workflow produces at the repo root does not fit that pattern.materializeFiles(files, dir = process.cwd())incore/src/utils/file_utils.ts:15is the only writer of agent output files; its call sites either pass an explicittempDir(unsafe_local_code_executor.ts:182) or are mocked in the unit tests, and the integration suites that exercise them either spawn withcwdset to their own fixture directory or record"outputFiles": []. Deletion alone is sufficient and complete.Duplicate-work disclosure (collision check). Per process I ran
gh pr list --repo AmaadMartin/adk-js --state open --limit 100before implementing. This change duplicates an existing open PR on this fork: #429 ("Chore: remove stray output.txt from the repository root"), whose three-dot delta is byte-identical to this one (D output.txt). Two further open PRs also remove the same path within broader work: #438 (the deletion plus isolating the cwd-writing skill-script integration tests) and #410 (the deletion plus routing skill script outputs to the artifact service). Only one of these should be merged — whichever lands first will make the others conflict. This PR is the minimal, single-purpose version; if #429 is preferred, close this one.Testing Plan
Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.
No tests were added or changed. This change contributes zero lines of production code, so there is nothing to cover, and an assertion that a specific file does not exist would be unmaintainable noise. The verification obligation here is the inverse — to prove nothing depended on the file — which the commands below do.
Unit Tests:
[ ] I have added or updated unit tests for my change. — N/A: the change adds no code. See above.
[x] All unit tests pass locally. (One pre-existing, unrelated failure, reproduced on the unmodified base — see below.)
The single failure is
dev/test/cli/cli_create_test.ts:214, which asserts on the Google Cloud project/region prompt and depends on local gcloud credentials that are absent in this environment. It is pre-existing and unrelated to this change — reproduced on the unmodified base commit withoutput.txtstill present:Per scope discipline it is reported, not fixed here.
CI note. The first CI attempt showed
run-tests (macos-latest)failing withTest timed out in 40000msattests/integration/app_loader/app_loader_test.ts:82, which cancelled the Windows job via matrix fail-fast. That is an unrelated flake, not a consequence of this diff: the testnpm installs a fixture intotests/integration/app_loader/discoveryinside a 40s cap and never touches the repository root, and re-running the failed jobs with no code change passed —run-tests (macos-latest)6m55s,run-tests (windows-latest)8m56s,run-tests (ubuntu-latest)5m32s, all green.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any necessary setup or configuration.
Ran after the full
unit:core+unit:devrun above: the worktree is clean andoutput.txtis absent, confirming no test recreates it at the repository root.Checklist
[x] I have read the CONTRIBUTING.md document.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas. — N/A: no code, this is a file deletion.
[ ] I have added tests that prove my fix is effective or that my feature works. — N/A: no code is added; see the Testing Plan for the evidence that nothing depended on the file.
[x] New and existing unit tests pass locally with my changes.