Skip to content

Ci: pin Node 24, install with npm ci, and fail validation when package-lock.json is out of date #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmaadMartin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ci: pin Node 24, install with npm ci, and fail validation when package-lock.json is out of date #467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c86ca65
ci: pin the validation toolchain and install from the lockfile
Aug 1, 2026
ebcd44b
ci: fail validation when package-lock.json is out of date
Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,25 @@ jobs:

- name: Use Node.js
uses: actions/setup-node@v6
with:
node-version: '24'

- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.11'

- name: Install dependencies
run: npm install
run: npm ci

- name: Check package-lock.json is up to date
if: matrix.os == 'ubuntu-latest'
run: |
npm install --package-lock-only
if ! git diff --exit-code package-lock.json; then
echo "::error file=package-lock.json::package-lock.json is out of date. Run 'npm install' locally and commit the regenerated package-lock.json."
exit 1
fi

- name: Check for secrets leaks
run: npx secretlint "**/*"
Expand Down
Loading