Skip to content

Fix: attribute cold AgentLoader discovery cost to beforeAll to stop macOS CI flake #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AmaadMartin wants to merge 2 commits into from
Closed

Fix: attribute cold AgentLoader discovery cost to beforeAll to stop macOS CI flake #260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c9366
test(integration): attribute cold AgentLoader discovery cost to befor…
Jul 29, 2026
1eca3e0
test(integration): condense fixture-timeout comments
Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions tests/integration/app_loader/app_loader_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ import {sendInput} from '../test_case_utils.js';
const execAsync = promisify(exec);
const dirname = process.cwd();
const TEST_EXECUTION_TIMEOUT = 40000;
// Fixture hooks shell out to `npm install` and recursively delete node_modules.
// That install/IO-bound work is far slower on a cold macOS CI runner than the
// assertions it sets up, so it gets its own ceiling.
const FIXTURE_SETUP_TIMEOUT = 180000;

describe('App loader CLI integration', () => {
describe.each(['app_ts', 'app_js', 'app_default'])(
Expand All @@ -29,7 +33,7 @@ describe('App loader CLI integration', () => {

beforeAll(async () => {
await execAsync('npm install', {cwd: projectPath});
}, TEST_EXECUTION_TIMEOUT);
}, FIXTURE_SETUP_TIMEOUT);

it(
'should run app via package.json start script and get responses',
Expand Down Expand Up @@ -62,7 +66,7 @@ describe('App loader CLI integration', () => {
await fs
.unlink(path.join(projectPath, 'package-lock.json'))
.catch(() => {});
}, TEST_EXECUTION_TIMEOUT);
}, FIXTURE_SETUP_TIMEOUT);
},
);
});
Expand All @@ -77,7 +81,10 @@ describe('AgentLoader discovery and loading integration', () => {
beforeAll(async () => {
await execAsync('npm install', {cwd: projectPath});
loader = new AgentLoader(projectPath);
}, TEST_EXECUTION_TIMEOUT);
// Discovery is lazy; warm it here so the one-time bundling cost is charged
// to setup rather than to whichever test runs first.
await loader.preloadAgents();
}, FIXTURE_SETUP_TIMEOUT);

it(
'should discover apps vs agents across directories and standalone files',
Expand Down Expand Up @@ -138,5 +145,5 @@ describe('AgentLoader discovery and loading integration', () => {
await fs
.unlink(path.join(projectPath, 'package-lock.json'))
.catch(() => {});
}, TEST_EXECUTION_TIMEOUT);
}, FIXTURE_SETUP_TIMEOUT);
});
Loading