[split 8/22] lightweight config: ConfigLoader type-tolerant parsing, EnvironmentVariables.getLabel() - #1363
Open
minguyen9988 wants to merge 1 commit into
Open
[split 8/22] lightweight config: ConfigLoader type-tolerant parsing, EnvironmentVariables.getLabel()#1363minguyen9988 wants to merge 1 commit into
minguyen9988 wants to merge 1 commit into
Conversation
…riables.getLabel() - ConfigLoader parsed every YAML value with a blind (String) cast: an unquoted numeric or boolean value (e.g. snapshot.new.tables: true) threw ClassCastException at startup. Values are now stringified explicitly; config_mixed_types.yml + ConfigLoaderTest pin it. - AppConfiguration: dead code removed. - EnvironmentVariables.getLabel() accessor; PropertiesHelper comparison fix. Part of the split of #1353 into independently mergeable sub-PRs (each <= 10 files), so the 2.10.0 branch can absorb the fixes incrementally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the split of #1353 into independently mergeable sub-PRs (each <= 10 files), so the 2.10.0 branch can absorb the fixes incrementally.
Split out of #1353, which this series replaces. Each sub-PR is <= 10 files; the union of all 22 reproduces the #1353 tree exactly (verified by tree SHA).