[split 7/22] deduplicator: fix eviction bug that never added keys to the FIFO pool, add concurrency test - #1362
Open
minguyen9988 wants to merge 1 commit into
Open
[split 7/22] deduplicator: fix eviction bug that never added keys to the FIFO pool, add concurrency test#1362minguyen9988 wants to merge 1 commit into
minguyen9988 wants to merge 1 commit into
Conversation
…, add concurrency test DeDuplicator.updateDedupePool() iterated over ALL topics' pools and attempted matchingQueue.remove(key) on an element already removeFirst()d - while never adding the new key to the current topic's queue. Eviction therefore never tracked insertions and the dedup map could grow without bound. Now: key appended to the per-topic FIFO, oldest entries evicted (from both queue and map) when maxPoolSize is exceeded. DeDuplicatorConcurrencyTest exercises the pool under parallel writers; DeDuplicatorTest expanded. Part of the split of #1353 into independently mergeable sub-PRs (each <= 10 files), so the 2.10.0 branch can absorb the fixes incrementally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeDuplicator.updateDedupePool() iterated over ALL topics' pools and attempted matchingQueue.remove(key) on an element already removeFirst()d - while never adding the new key to the current topic's queue. Eviction therefore never tracked insertions and the dedup map could grow without bound. Now: key appended to the per-topic FIFO, oldest entries evicted (from both queue and map) when maxPoolSize is exceeded. DeDuplicatorConcurrencyTest exercises the pool under parallel writers; DeDuplicatorTest expanded.
Part of the split of #1353 into independently mergeable sub-PRs (each <= 10 files), so the 2.10.0 branch can absorb the fixes incrementally.
Split out of #1353, which this series replaces. Each sub-PR is <= 10 files; the union of all 22 reproduces the #1353 tree exactly (verified by tree SHA).