-
Notifications
You must be signed in to change notification settings - Fork 6
Fix helm on eks #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix helm on eks #11
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,8 @@ spec: | |
| nodes: | ||
| - host: keeper-keeper | ||
| port: 2181 | ||
| users: | ||
| root/password: topsecret | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can wait for a later PR but we should use secrets rather than expose passwords. See https://altinity.com/blog/clickhouse-confidential-using-kubernetes-secrets-with-the-altinity-operator#using-secrets-to-protect-clickhouse-user-passwords for more information.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will look into using secrets. But this section was added so the test_vector_sever_version auth header here works. If the test is changed to not use the auth header, this root password is not needed. Not sure if that's an issue with the test or if we do need a root password specified, because I don't see this password in the docker compose setup. |
||
| files: | ||
| config.d/remote_servers.xml: | | ||
| <clickhouse> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.