Casimir43/enhancement/665 refactor baseauthform card layout loginform link

[Casimir43]

📄 Pull Request Overview

Closes #665

🔧 Changes Made

1. Gave the login form a proper card look to match the Figma design, on desktop and mobile. Added a "Register in-game" link on the login form that takes you to the Google Play page. Updated the Finnish and English texts for the new labels and that register link. Added/updated tests for the login form.

2. Cleaned up the login form test.

---

✅ Checklist Before Submission

• Functionality: I have tested my code, and it works as expected. ✅
• JSDoc: I have added or updated JSDoc comments for all relevant code. ✅
• Debugging: No console.log() or other debugging statements are left. ✅
• Clean Code: Removed commented-out or unnecessary code. ✅
• Tests: Added new tests or updated existing ones for the changes made. ✅
• Documentation: Documentation has been updated (if applicable). ✅

---

📝 Additional Information

[codecov-alt]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
...src/entities/Auth/ui/BaseAuthForm/BaseAuthForm.tsx	100.00% <100.00%> (ø)
...features/AuthByUsername/ui/LoginForm/LoginForm.tsx	94.11% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Skoivumaki]

Nice work. Good use of variables, just as expected and updating tests is also much appreciated. Just fix the small thing to utilize compiler 👍
Random question: Does "Remember me" toggle do anything upon login?

[Skoivumaki]

Use Image instead of img so Next can optimize upon build.

[Skoivumaki]

This is wild. Shame SCSS doesnt understand @/shared...

[Casimir43]

Nice work. Good use of variables, just as expected and updating tests is also much appreciated. Just fix the small thing to utilize compiler 👍 Random question: Does "Remember me" toggle do anything upon login?

Purely visual, didnt think it was part of this issue. Should i make it actually work? it's not going to be part of seperate issue in the future?

[Varkopat]

Looks good to me. Like Sakari said, you have good use of variables. You updated tests well, that's also an important thing to do.

I see that you have fixed the code to use the Image tag correctly. I think this issue gets finished when you do the rest of the requested changes👍