fix(auth): migrate user base paths to scoped roles - #9641
Open
okatu-loli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users whose base path matches a role scope can resolve a selected path twice (for example,
/教学becomes/教学/教学). Keep user base paths at/and migrate existing non-root restrictions into roles so upgrading does not broaden their directory scope.Changes
/; retire default-directory settings in favor of role scopes./do not get per-user roles; ordinary shared roles remain unchanged.Validation
-race, plus command-package tests and application build.go test ./internal/... ./server/... ./cmd/...has three failures also reproduced on unmodified upstreame1c022a9:TestSecureJoin/driveon macOS,TestDownloadOrder, and the existingserver/s3/backend.go:331log-format vet error.Compatibility
Clients must use full virtual paths after upgrading. Existing SSO/LDAP default-directory isolation becomes role-based. Coordinate release with the companion frontend PR: AlistGo/alist-web#311. Live protocol checks used local storage; external identity providers and all remote drivers were not exercised.