Skip to content

[PWGJE] jetHadronsPid task: Improve PID methods and fix list of includes#16997

Draft
llorenc-11 wants to merge 34 commits into
AliceO2Group:masterfrom
llorenc-11:PID-Hadrons-in-Jets
Draft

[PWGJE] jetHadronsPid task: Improve PID methods and fix list of includes#16997
llorenc-11 wants to merge 34 commits into
AliceO2Group:masterfrom
llorenc-11:PID-Hadrons-in-Jets

Conversation

@llorenc-11

Copy link
Copy Markdown
Contributor

Adding configurable group for setting up PID and function getPid for default usage in the task.
Adding histograms for positively and negatively charged hadrons.
Fixing list of include headers and used namespaces.

llorenc-11 and others added 30 commits April 27, 2026 16:49
@github-actions github-actions Bot added the pwgje label Jul 9, 2026
@github-actions github-actions Bot changed the title [PWGJE] jetHadronsPid task: Improve PID methods and fix list of includes [PWGJE] jetHadronsPid task: Improve PID methods and fix list of includes Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@llorenc-11 llorenc-11 marked this pull request as ready for review July 10, 2026 07:41
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e0a061a at 2026-07-10 09:52:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 99 warnings.'
Found 5 errors and 99 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/6c335f24fe33eac3db8088854877ebec13e0d13b/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetHadronsPid.cxx:434:12: error: variable 'dPi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetHadronsPid.cxx:435:12: error: variable 'dKa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetHadronsPid.cxx:436:12: error: variable 'dPr' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGJE/Tasks/jetHadronsPid.cxx:458:18: error: use designated initializer list to initialize 'PidResult' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetHadronsPid.cxx:803:29: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
++ [[ 99 -gt 0 ]]
++ cat /sw/BUILD/6c335f24fe33eac3db8088854877ebec13e0d13b/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetHadronsPid.cxx:461:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:463:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:465:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:468:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:470:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:472:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:475:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:477:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:479:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:483:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:485:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:487:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:496:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:498:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:500:99: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:502:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:504:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:506:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:508:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:510:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:512:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:514:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:521:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:523:93: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:525:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:527:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:529:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:531:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:533:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:537:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:550:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:559:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:567:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:578:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetHadronsPid.cxx:587:30: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@llorenc-11 llorenc-11 marked this pull request as draft July 10, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants