Repository navigation
Report a plist with an unknown encoding instead of crashing - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78.
markfind importcrashed with a traceback on a property list whose XML declaration names an encoding Python doesn't have.plistlibraisesLookupError, which was not among the exceptionsparse_safari_plistturns into "not a readable Safari bookmarks file", so it escaped pastcmd_import's handler.Now it is reported like any other unreadable file, with exit code 1.
How I found it
I fuzzed the query path and the parsers, looking for anything that escapes as an unexpected exception:
to_fts_query+Store.search, plain and rawextract_texton malformed markupload_fileon mutated bookmark files of every formatcanonical_urlon malformed URLsSo this was the only hole, and the query path in particular came through clean.
Tests
The bad encoding joins the existing
test_corrupt_plistcases, and a new test drives it throughmarkfind importto check it exits 1 with a message rather than a traceback. Re-running the fuzzer afterwards reports nothing unexpected.413 tests pass, ruff clean.