ci(security): strengthen static analysis checks - #2789
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
=========================================
Coverage 93.48% 93.48%
Complexity 5731 5731
=========================================
Files 918 918
Lines 21874 21875 +1
Branches 2020 2020
=========================================
+ Hits 20449 20450 +1
Misses 801 801
Partials 624 624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fb6e28e30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| timeout-minutes: 45 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
Disable persisted checkout credentials before PR builds
For same-repository pull_request runs where the requested token permissions are granted, this checkout happens before running PR-controlled Gradle code while the job has security-events: write; actions/checkout persists the token in local git config by default, so a malicious build script can read and reuse that credential before the CodeQL upload. Set persist-credentials: false here unless the build actually needs authenticated git operations.
Useful? React with 👍 / 👎.
Goal
Strengthen the project's static-analysis and dependency security gates based on the verified Kaicode evaluation findings. CI should report violations without modifying source files, preserve exception context, and add SAST and pull-request dependency review coverage.
Changes
--no-auto-correct.ProtectedMemberInFinalClass,UnnecessaryAbstractClass,SwallowedException, andThrowingExceptionsWithoutMessageOrCauserules while leaving the previously identified high-noise rules disabled.IllegalStateException, and document the intentional unknown-event fallback toJsonDomainEvent.main, a weekly schedule, and manual dispatch.Verification
./gradlew :wow-core:test --tests "me.ahoo.wow.modeling.annotation.AggregateMetadataParserTest" --tests "me.ahoo.wow.serialization.JsonSerializerPolymorphicTest" --no-daemon— passed../gradlew detekt --no-auto-correct --stacktrace --no-daemon— passed across 31 Detekt tasks../gradlew classes --no-daemon— passed across 81 tasks and validates the CodeQL manual build command.git diff --check— passed.Risks and Notes